Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo contract always updates the crates.io index #926

Closed
athei opened this issue Jan 25, 2023 · 0 comments · Fixed by #948
Closed

cargo contract always updates the crates.io index #926

athei opened this issue Jan 25, 2023 · 0 comments · Fixed by #948
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@athei
Copy link
Contributor

athei commented Jan 25, 2023 •
edited
Loading

On every rebuild of a contract the crates.io index is checked before building. That should not be the case with a lock file. Adds a small annoying delay to every rebuild.

The reason for that is probably because cargo contract overwrites the Cargo.toml for every build.
@cmichi cmichi added good first issue Good for newcomers bug Something isn't working labels Jan 25, 2023
@athei athei mentioned this issue Jan 25, 2023
Open
@athei athei changed the title cargo contract always updates the crates.io index cargo contract always updates the crates.io index and does not respect the lockfile Feb 1, 2023
@athei athei changed the title cargo contract always updates the crates.io index and does not respect the lockfile cargo contract always updates the crates.io index Feb 1, 2023
@athei athei mentioned this issue Feb 1, 2023
Closed
@ascjones ascjones mentioned this issue Feb 3, 2023
Merged
@athei athei mentioned this issue Feb 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Respect the lockfile use-ink/cargo-contract
2 participants
@cmichi @athei