Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment of branches not configured for deployment on project #2904

Closed
xantrix opened this issue Nov 3, 2021 · 2 comments · Fixed by #2909 or #2912
Closed

Deployment of branches not configured for deployment on project #2904

xantrix opened this issue Nov 3, 2021 · 2 comments · Fixed by #2909 or #2912

Comments

@xantrix
Copy link
Contributor

xantrix commented Nov 3, 2021

Describe the bug

Few customers reported that branches not configured for deployment (not present in the branches regex string) are deployed anyway

Expected behavior

honor the branches string regex for deployments

@Schnitzel
Copy link
Contributor

after some research it seems this only happens for environments that have been created in the past and then deleted. The new DeployTarget Logic doesn't check that the environment has already been deleted and just creates it again.
I think this happens here:

const apiEnvironment = await getEnvironmentByName(branchName, projectId);

@vincenzodnp
Copy link
Contributor

@shreddedbacon the same happens with the PR regex.
For example, setting it to false allows the creation of environments based on a PR regardless of the PR regex.
ps: the regex envs didn't exist before, so they are brand-new envs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants