Skip to content

Commit

Permalink
feat: write memo UID in file names when exporting to Markdown (#3712)
Browse files Browse the repository at this point in the history
When using the "export to Markdown" feature in Memos, the files included in the ZIP folder don't feature any kind of reference to their alphanumeric UID from the server's database, which completely breaks the point of links inside the files made with the `[[memos/<uid>]]` format, since it's impossible to know which Markdown file this kind of string inside other files refers to.

This pull request modifies the ExportMemos server function, to add the UID of every memo immediately after the date in the filename. For example, an exported memo would now be called: `YYYY-MM-DDThh:mm:ss+hh:mm-AbcDefGhiJklMnoPqrStu1-PUBLIC.md`.
  • Loading branch information
andrigamerita authored Jul 18, 2024
1 parent fefe2b0 commit af95280
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion server/router/api/v1/memo_service.go
Original file line number Diff line number Diff line change
Expand Up @@ -601,7 +601,7 @@ func (s *APIV1Service) ExportMemos(ctx context.Context, request *v1pb.ExportMemo
if err != nil {
return nil, errors.Wrap(err, "failed to convert memo")
}
file, err := writer.Create(time.Unix(memo.CreatedTs, 0).Format(time.RFC3339) + "-" + string(memo.Visibility) + ".md")
file, err := writer.Create(time.Unix(memo.CreatedTs, 0).Format(time.RFC3339) + "-" + memo.UID + "-" + string(memo.Visibility) + ".md")
if err != nil {
return nil, status.Errorf(codes.Internal, "Failed to create memo file")
}
Expand Down

0 comments on commit af95280

Please sign in to comment.