Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename refactoring] Stricter checks & tests for change annotations #527

Open
toinehartman opened this issue Nov 19, 2024 · 0 comments
Open
Assignees

Comments

@toinehartman
Copy link
Contributor

Problem

Rename refactoring supports annotating suggested edits with a label/description, and a 'needs confirmation' flag. Currently, due to programmer error, if an edit to the same location is registered multiple times, annotations could overwrite each other, leading to unpredictable behaviour. Currently, annotations are only use for instances of has, but when they become more widespread, this can lead to unexpected results.

Requested solution

  1. Impose stricter checks on change annotations in the unit test framework.
  2. Refactor rename location<>change annotation bookkeeping to make this less likely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant