-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDDSA/sigVer test vectors are always for pureEdDSA even with preHash=true #268
Comments
Thanks @naogot. Received. We'll take a look. |
Edit: Removed other text. I thought EdDSA pre-hash would be similar to the signature component (pre-hash) options for ECDSA. The code we have implemented is identical to FIPS 186-5. Turns out hashEdDSA still expects an arbitrary bitstring @naogot if I drop a vector set here for Ed25519, would you be able to test it out? |
Thank you so much, @celic. Our result is consistent with expectedResults.json in the zip. |
Thanks. I'll make sure this goes into the next release. |
The fix for this is on Demo in release v1.1.0.30 |
Thanks a lot, it is working fine. |
The fix for this is on Prod in release v1.1.0.30 |
environment
Demo
testSessionId
413264
vsId
1688669
Algorithm registration
Endpoint in which the error is experienced
https://demo.acvts.nist.gov/acvp/v1/
Expected behavior
According to the expected results, the signature verification should be successful in tcId:5, but it failed. When I tried to process it as pureEdDSA (overwrote as "preHash": false), the verification succeeded.
Additional context
Not sure if it is really related, but the following code does not care _param.PreHash (handled as false by default parameter).
https://github.com/usnistgov/ACVP-Server/blob/master/gen-val/src/orleans/src/NIST.CVP.ACVTS.Libraries.Orleans.Grains/Eddsa/OracleObserverEddsaVerifySignatureCaseGrain.cs
The text was updated successfully, but these errors were encountered: