Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECDSA SigVer gives componentTest:true test groups when not requested for SHAKE #336

Closed
abkarcher opened this issue May 29, 2024 · 8 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@abkarcher
Copy link

environment
Demo

testSessionId
514488

vsId
2358750

This test session was requested with componentTest: false for all vector sets. However, the ECDSA sigver test groups have true for componentTest when using SHAKE hash algs.

Might anyone be able to confirm if they have been able to pass ECDSA siggen/sigver testing using SHAKE in general?

Thanks,
Andrew

@jbrock24
Copy link
Collaborator

Hi @abkarcher, I'll take a look into this, thanks for letting us know.

@jbrock24 jbrock24 self-assigned this May 29, 2024
@livebe01
Copy link
Collaborator

livebe01 commented May 31, 2024

Hi @abkarcher, do you know if this is a new behavior as of release v1.1.0.34? Or pre-existing issue?

Also, @szendros seems to have been able to test against ECDSA siggen/sigver using SHAKE successfully I believe. See #301 (comment)

@abkarcher
Copy link
Author

abkarcher commented Jun 3, 2024

Hi,

Sorry, I seem to have missed the notification for this. I am not aware if this issue existed prior to .34, I did not notice it until after.

I am seeing all sorts of failures testing siggen/sigver with a basic implementation with SHAKE, with some specific test groups working fine. I will continue to look into it on my end.

Thanks,
Andrew

@livebe01
Copy link
Collaborator

livebe01 commented Jun 4, 2024

K, thanks Andrew.

@jbrock24
Copy link
Collaborator

jbrock24 commented Jun 5, 2024

Hi @abkarcher,

This is indeed a bug I added with the last hot fix, I have refactored and fixed the bug. It will go out with the next release.

As far as usage goes, this is actually just an issue with it being set incorrecly, but not used. So, in this case, the setting is showing as True, but it's actually False. So, the test data should be fine.

Thanks,
Joel

@jbrock24 jbrock24 added the bug Something isn't working label Jun 5, 2024
@jbrock24 jbrock24 added this to the v1.1.0.35 milestone Jun 5, 2024
@abkarcher
Copy link
Author

Thanks!

@livebe01
Copy link
Collaborator

The fix for this is on Demo in release v1.1.0.35.

@livebe01
Copy link
Collaborator

The fix for this is on Prod in release v1.1.0.35.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants