Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EdDSA secretGenerationMode does not match FIPS 186-5 #1422

Closed
jvdsn opened this issue Mar 3, 2023 · 7 comments
Closed

EdDSA secretGenerationMode does not match FIPS 186-5 #1422

jvdsn opened this issue Mar 3, 2023 · 7 comments
Milestone

Comments

@jvdsn
Copy link
Contributor

jvdsn commented Mar 3, 2023

FIPS 186-5 doesn't specify a secretGenerationMode for EdDSA. Appendix A.2.3 simply says:

Obtain a string of b bits from an approved DRBG (as specified in SP 800-90A [16]) with a security strength of requested_security_strength or more. The private key d is this string of b bits.

This should be removed from https://github.com/usnistgov/ACVP/blob/master/src/eddsa/sections/05-eddsa-keygen-capabilities.adoc

@jbrock24
Copy link
Collaborator

@jvdsn Just to touch base that I have researched this and will have a response soon. Thanks!

@jbrock24
Copy link
Collaborator

jbrock24 commented May 4, 2023

Hi @jvdsn. it appears this is leftover from early drafts or implementation. I will remove it from the documentation and from the actual algorithm's registration requirements. Thanks for the help! I'll update this once it's pushed for users, I am going to have a another HOTFIX out for OID's soon, it will hopefully go out with that.

@livebe01 livebe01 added this to the v1.1.0.29 milestone May 24, 2023
@livebe01
Copy link
Collaborator

livebe01 commented Jun 1, 2023

The fix for this is now on Demo in release v1.1.0.29.

@jvdsn
Copy link
Contributor Author

jvdsn commented Jun 1, 2023

@livebe01 was this more than a documentation issue? For what it's worth, the documentation still specifies this

@jbrock24
Copy link
Collaborator

jbrock24 commented Jun 1, 2023

I will remove the documentation, thanks @jvdsn - I did remove it from the code. Appreciated!

@jbrock24 jbrock24 closed this as completed Jun 1, 2023
@jbrock24
Copy link
Collaborator

jbrock24 commented Jun 1, 2023

Documentation merge is here: #1445, thanks again.

@livebe01
Copy link
Collaborator

The fix for this is on Prod in release v1.1.0.29-hotfix-1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants