Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACVP RSA Algorithm JSON Specification issues #1451

Closed
mmccarl opened this issue Jun 15, 2023 · 4 comments
Closed

ACVP RSA Algorithm JSON Specification issues #1451

mmccarl opened this issue Jun 15, 2023 · 4 comments
Assignees
Milestone

Comments

@mmccarl
Copy link

mmccarl commented Jun 15, 2023

There are a couple issues in the ACVP RSA Algorithm JSON Specification that I noticed:

  1. Table 13 indicates that the JSON value "modulo" is to be included in the RSA/signaturePrimitive/2.0 registration, however the sample JSON has "modulus". Submitting with "modulo" generates the error message "RSA-signaturePrimitive-2.0: No modulo supplied.". Both the spec and the error message need to be updated to say "modulus".
  2. The Figure 1 and the example of an RSA/signaturePrimitive/2.0 registration includes "isSample" within the algorithm entry, but isSample is not in Table 13. "isSample" should probably not be included in any of the example registrations.
@jbrock24 jbrock24 self-assigned this Jul 20, 2023
@jbrock24
Copy link
Collaborator

@mmccarl Thanks for letting me, I'll fix all of this.

@jbrock24
Copy link
Collaborator

Just to clarify, this is complete, it will go out with the next release!

@livebe01
Copy link
Collaborator

The fix for this is on Demo in release v1.1.0.31.

@livebe01
Copy link
Collaborator

The fix for this is on Prod in release v1.1.0.31.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants