Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pubExpMode random provides non-approved e values #1460

Closed
jvdsn opened this issue Aug 14, 2023 · 4 comments
Closed

pubExpMode random provides non-approved e values #1460

jvdsn opened this issue Aug 14, 2023 · 4 comments
Assignees
Milestone

Comments

@jvdsn
Copy link
Contributor

jvdsn commented Aug 14, 2023

Technically, this is a duplicate of #1116, which @celic marked as a duplicate of #1061. However, I'd like to open the discussion again, and my request is more constrained than the other two issues.

For pubExpMode random, the server sometimes provides e values that are not approved. For example, for test session 429889, vector set 1781060, test group 25, I got an e value of "03". This is clearly not conformant to FIPS 186-4 and FIPS 186-5, which was pointed out in #1116.

The ACVP server should not provide those values; it should only provide random values within the range specified by FIPS 186-4 and FIPS 186-5: "The exponent e shall be an odd, positive integer such that $2^{16} < e < 2^{256}$."

I currently don't care about any other constraints/ranges. Thus, this change shouldn't require a protocol update, simply a server update.

@jvdsn
Copy link
Contributor Author

jvdsn commented Aug 26, 2023

Any update on this?

@jbrock24
Copy link
Collaborator

Hi @jvdsn , currently working on it, will let you know soon.

@jbrock24 jbrock24 self-assigned this Aug 30, 2023
@jbrock24
Copy link
Collaborator

Was able to track down the culprit behind this, the fix will go out with the next release. I'll post here when it's ready, thanks @jvdsn

@livebe01 livebe01 added this to the v1.1.0.31 milestone Sep 20, 2023
@livebe01
Copy link
Collaborator

The fix for this is on Prod in release v1.1.0.31.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants