Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider the eclipse effect by the moon and other planets #8

Closed
3 tasks done
200km opened this issue Jan 4, 2022 · 2 comments · Fixed by #532
Closed
3 tasks done

Consider the eclipse effect by the moon and other planets #8

200km opened this issue Jan 4, 2022 · 2 comments · Fixed by #532
Assignees
Labels
environment environment calculation good first issue Good for newcomers minor update add functionality in a backwards compatible manner priority::medium priority medium

Comments

@200km
Copy link
Member

200km commented Jan 4, 2022

Overview

Consider the eclipse effect caused by the moon and other planets for deep space mission analysis.

Details

  • Add the effect of the eclipse by the moon in the SRPEnvironment class.
  • Add the effect of the eclipse by other selected planets in the SRPEnvironment class.
  • Add the input interface to select the eclipse is calculated or not.

Conditions for close

When the above tasks are completed.

Supplement

NA

Note

@200km 200km added the priority::medium priority medium label Jan 4, 2022
@200km
Copy link
Member Author

200km commented Feb 17, 2022

中心天体を任意で選択できるようになったが、地球と月の蝕どちらも考えるというのはまだできていない。

@200km 200km added environment environment calculation minor update add functionality in a backwards compatible manner labels Nov 22, 2022
@200km 200km added the good first issue Good for newcomers label Dec 10, 2022
@200km
Copy link
Member Author

200km commented Dec 29, 2022

@tarataratatata このissueは、SRPEnvironmentに月などの蝕の効果を入れるというものになります。

CalcShadowCoefficientという関数の引数に、月などをいれるというだけなのですが、その辺りのインターフェースを追加するというのが主な実装項目となります。

@200km 200km added this to the Minor update v6.1.0 milestone Apr 12, 2023
@200km 200km removed this from the Major Update for v7.0.0 milestone Aug 25, 2023
@200km 200km added this to the Major Update v8.0.0 milestone Sep 27, 2023
@200km 200km self-assigned this Oct 10, 2023
@200km 200km linked a pull request Oct 30, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
environment environment calculation good first issue Good for newcomers minor update add functionality in a backwards compatible manner priority::medium priority medium
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants