Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review fn queryRgbppLockTxByBtcTx and queryBtcTimeLockTxByBtcTxId #193

Closed
1 task done
Flouse opened this issue Jul 11, 2024 · 0 comments · Fixed by #194
Closed
1 task done

Review fn queryRgbppLockTxByBtcTx and queryBtcTimeLockTxByBtcTxId #193

Flouse opened this issue Jul 11, 2024 · 0 comments · Fixed by #194
Assignees
@ShookLyngs
Labels
bug Something isn't working

Comments

@Flouse
Copy link
Contributor

Flouse commented Jul 11, 2024 •
edited
Loading

  1. If someone creates a new rgbpp-lock cell bound to one UTXO in btcTx, the result of fn queryRgbppLockTxByBtcTx may be inaccurate.
    Originally posted by @Flouse in feat: add rgbpp address activity api  #182 (comment)

    A new filter rule may be required:

    • Let's say btcTx and ckbTx are isomophic
    • One of the ckbTx inputs should be a rgbpp-lock that bound with one of the btcTx inputs
@Flouse Flouse mentioned this issue Jul 12, 2024
Merged
@Flouse Flouse added the bug Something isn't working label Jul 13, 2024
@ShookLyngs ShookLyngs mentioned this issue Jul 18, 2024
Merged
3 tasks
@Flouse Flouse linked a pull request Aug 21, 2024 that will close this issue
fix: duplicated bindings in the activity API #194
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShookLyngs ShookLyngs

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: duplicated bindings in the activity API utxostack/btc-assets-api
2 participants
@Flouse @ShookLyngs