Deleted comment from GH makes sync to fail

[lgecse]

Steps to reproduce:

• Make a GH issue, have some comments on it
• Run sync tool, should be successful
• Go to GH, remove a comment from the synced issue
• Run sync tool again, will fail

DEBU Updating Jira OSE-15 with GitHub #1           file="issue/issue.go:187"
DEBU Comparing GitHub issue #1 and Jira issue OSE-15  file="issue/issue.go:124"
DEBU Issues have any differences: false            file="issue/issue.go:172"
DEBU Jira issue OSE-15 is already up to date!      file="issue/issue.go:245"
DEBU Jira issue OSE-15 has 5 comments              file="comment/comment.go:77"
DEBU Retrieving GitHub user (rappizs)              file="github/github.go:115"
ERRO Update Jira comment did not return comment! Got: <nil>  file="jira/jira.go:457"
ERRO Error updating issue OSE-15. Error: comparing comments for issue OSE-15: updating Jira comment: update Jira comment fail

Edit: updated description, and title. GH comment removal makes the tool fail.

[rappizs]

We have two options for the solution, if a comment has been deleted on GitHub:

• we can remove it from Jira as well
• we can flag the comment in Jira somehow to indicate that it has been deleted on GitHub, but we don't actually remove the comment from Jira

Which solution would we prefer @justaugustus?

[lgecse]

@rappizs Please go ahead with

we can flag the comment in Jira somehow to indicate that it has been deleted on GitHub, but we don't actually remove the comment from Jira

[rappizs]

@lgecse I couldn't reproduce this issue. After deleting a comment on GH everything works fine, except the comment is still in Jira, but I can't see any errors.