[Umbrella] Update issue bugs

[justaugustus]

Progress tracker for fixing bugs around issue updates

• Update operations fail because fields cannot be set: Update operations fail because fields cannot be set #30
• Issue creation fails with generic message: Issue creation fails with generic message #10
• Comment regular expression is fragile: Comment regular expression is fragile #9
• When updating issues, only first 50 Jira issues are considered: When updating issues, only first 50 Jira issues are considered #8
• Comments are not being added to issues: Comments are not being added to issues #62

[justaugustus]

Status as of 679e06c...

Create

DEBU[0000] Collecting issues                             app=gh-jira-issue-sync
DEBU[0000] Collected all GitHub issues                   app=gh-jira-issue-sync
DEBU JQL query used: project='OSPO' AND cf[10042] in (1508102635,1508156032,1508275026,1508277393,1508279848,1508281529,1508283201,1508285716,1508289389,1508292244,1508295508,1508480333,1510075038,1510219671,1510226238,1510227591,1510232731,1510233097,1510233198,1510233251,1510233347,1510233380,1510233426,1510233465,1510233612,1511986797,1512044441,1512263025)  file="jira/jira.go:168"
DEBU[0001] Jira issues found: 0                          app=gh-jira-issue-sync
DEBU[0001] Collected all JIRA issues                     app=gh-jira-issue-sync
DEBU[0001] GitHub ID custom field key: customfield_10042  app=gh-jira-issue-sync
DEBU[0001] Creating JIRA issue based on GitHub issue #4  app=gh-jira-issue-sync
ERRO[0001] Error creating JIRA issue: backoff error: %!w(<nil>)  app=gh-jira-issue-sync
ERRO[0001] Error occurred trying to read error body: http2: response body closed  app=gh-jira-issue-sync
ERRO[0001] Error creating issue for #4. Error: creating Jira issue: reading error body: http2: response body closed  app=gh-jira-issue-sync

Update

DEBU[0000] Collecting issues                             app=gh-jira-issue-sync
DEBU[0000] Collected all GitHub issues                   app=gh-jira-issue-sync
DEBU JQL query used: project='OSPO' AND cf[10042] in (1508102635,1508156032,1508275026,1508277393,1508279848,1508281529,1508283201,1508285716,1508289389,1508292244,1508295508,1508480333,1510075038,1510219671,1510226238,1510227591,1510232731,1510233097,1510233198,1510233251,1510233347,1510233380,1510233426,1510233465,1510233612,1511986797,1512044441,1512263025)  file="jira/jira.go:168"
DEBU[0001] Jira issues found: 28                         app=gh-jira-issue-sync
DEBU[0001] Collected all JIRA issues                     app=gh-jira-issue-sync
DEBU[0001] GitHub ID custom field key: customfield_10042  app=gh-jira-issue-sync
INFO[0001] updating issue 10132                          app=gh-jira-issue-sync
DEBU[0001] Updating JIRA OSPO-133 with GitHub #4         app=gh-jira-issue-sync
DEBU[0001] Comparing GitHub issue #4 and JIRA issue OSPO-133  app=gh-jira-issue-sync
DEBU[0001] Issues have any differences: false            app=gh-jira-issue-sync
DEBU[0001] JIRA issue OSPO-133 is already up to date!    app=gh-jira-issue-sync
ERRO[0001] Error retrieving JIRA issue: backoff error: %!w(<nil>)  app=gh-jira-issue-sync
ERRO[0001] Error occurred trying to read error body: http2: response body closed  app=gh-jira-issue-sync
ERRO[0001] Error updating issue OSPO-133. Error: getting Jira issue OSPO-133: reading error body: http2: response body closed  app=gh-jira-issue-sync

---

So, a few things:

• Backoff logic appears to throwing erroneous... errors. Issues are actually created.
• Comments have not been added to issues. It appears the comparison logic is invalid/incomplete and comparisons for certain fields, like comments, do not appear to happen until after the issues have been determined to not have any differences.