-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add saline server container #9451
Add saline server container #9451
Conversation
089cbf5
to
be0bf41
Compare
be0bf41
to
8af40f9
Compare
8af40f9
to
fa4069f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optional
@vzhestkov did you try to build the container pushing it to OBS?
|
fa4069f
to
7458014
Compare
Are you pushing it using the automation or manually? |
@deneb-alpha , manually, as I know nothing about the automation for it.
Do we have any description how new containers should be submitted? |
you can submit to a test IBS/OBS project with https://github.com/uyuni-project/uyuni/wiki/Building-an-RPM-in-an-OBS-branch-package In particular, I think in this case we will need a regular .changes instead of the one generated automatically by mkchglog. No need to add the full .changes template with author, date etc, but I think we need one for pushing to IBS/OBS. |
7458014
to
ded864c
Compare
@deneb-alpha done, thanks for pointing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vzhestkov
I prepared a PR with the needed fixes for this PR.
With the changes I proposed in this pull request (vzhestkov#1) the automation is working and the container can be pushed and tagged automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vzhestkov from releng POV, LGTM
|
What does this PR change?
Adds server container with Saline inside.
GUI diff
No difference.
Before:
After:
Documentation
Documentation issue was created: https://github.com/SUSE/spacewalk/issues/25993
DONE
Test coverage
ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite
No tests: add explanation
No tests: already covered
Unit tests were added
Cucumber tests were added
DONE
Links
Issue(s): #
Port(s): # add downstream PR(s), if any
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!