Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle upcoming new CDN #9541

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mcalmer
Copy link
Contributor

@mcalmer mcalmer commented Dec 5, 2024

What does this PR change?

We discuss to switch the CDN and this require a little code changes

GUI diff

No difference.

  • DONE

Documentation

Test coverage

  • No tests: manual

  • DONE

Links

Issue: https://github.com/SUSE/spacewalk/issues/25954
Port(s): TBD

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@mcalmer mcalmer requested a review from a team as a code owner December 5, 2024 09:13
@mcalmer mcalmer requested review from lucidd and mackdk and removed request for a team December 5, 2024 09:13
Copy link
Contributor

github-actions bot commented Dec 5, 2024

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9541/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9541/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Suggested tests to cover this Pull Request
  • proxy_cobbler_pxeboot
  • srv_monitoring
  • srv_rename_hostname
  • proxy_branch_network
  • allcli_sanity
  • srv_sync_channels
  • srv_menu
  • srv_first_settings
  • srv_task_status_engine
  • srv_sync_products
  • srv_enable_sync_products

mackdk
mackdk previously approved these changes Dec 5, 2024
rjmateus
rjmateus previously approved these changes Dec 5, 2024
lucidd
lucidd previously approved these changes Dec 6, 2024
@mcalmer mcalmer dismissed stale reviews from lucidd, rjmateus, and mackdk via 79e9938 December 7, 2024 12:59
@mcalmer mcalmer force-pushed the cdn-change-project branch from d3b59f1 to 79e9938 Compare December 7, 2024 12:59
@digitaltom
Copy link

Is there a way to avoid the hardcoding of SUSE CDN urls and parameter names? This limits how we can adjust the setup in the future.

@mcalmer
Copy link
Contributor Author

mcalmer commented Dec 13, 2024

Is there a way to avoid the hardcoding of SUSE CDN urls and parameter names? This limits how we can adjust the setup in the future.

We need to distinguish between SUSE CDN and other CDNs like Nvidia, Ubuntu, Centos, IBM, RedHat, etc.
Can we agree that SCC only report repository URLs for SUSE CDN on domain .suse.com than we can check only for the domain.
Or SCC need to provide a flag which say "onSUSECDN: true" or something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants