Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show versions for 'kernel-default' in CLM Live Patching template (bsc#1233400) #9549

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

cbbayburt
Copy link
Contributor

"Live patching for a product" filter in CLM shows versions of all the available kernels in a dropdown, including kernel-default-base and any other flavours. Since live patching is only available for kernel-default, this change excludes the versions from other kernel packages from the dropdown list.

Port of #25987 (Manager-4.3)

Links

Issue: https://github.com/SUSE/spacewalk/issues/25813

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@cbbayburt cbbayburt requested a review from a team as a code owner December 6, 2024 20:22
@cbbayburt cbbayburt requested review from rjmateus and removed request for a team December 6, 2024 20:22
Copy link
Contributor

github-actions bot commented Dec 6, 2024

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9549/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9549/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Suggested tests to cover this Pull Request
  • sle_ssh_minion
  • min_salt_migration
  • min_salt_install_with_staging
  • srv_create_repository
  • proxy_register_as_minion_with_script
  • min_deblike_salt
  • allcli_overview_systems_details
  • min_salt_formulas
  • min_project_lotus
  • srv_docker_cve_audit
  • minssh_move_from_and_to_proxy
  • min_salt_install_package
  • srv_disable_local_repos_off
  • srv_datepicker
  • min_salt_openscap_audit
  • minkvm_guests
  • min_monitoring
  • min_recurring_action
  • min_salt_minion_details
  • min_rhlike_openscap_audit
  • srv_distro_cobbler
  • srv_menu_filter
  • srv_custom_system_info
  • min_salt_minions_page
  • srv_enable_sync_products
  • min_deblike_salt_install_package
  • min_empty_system_profiles
  • min_cve_id_new_syntax
  • min_ssh_tunnel
  • min_move_from_and_to_proxy
  • srv_delete_channel_with_tool
  • min_ansible_control_node
  • srv_power_management_redfish
  • min_bootstrap_script
  • allcli_update_activationkeys
  • min_rhlike_monitoring
  • srv_channel_api
  • allcli_software_channels_dependencies
  • srv_content_lifecycle
  • srv_add_rocky8_repositories
  • min_cve_audit
  • srv_task_status_engine
  • min_salt_mgrcompat_state
  • min_config_state_channel
  • srv_reportdb
  • srv_delete_channel_from_ui
  • buildhost_bootstrap
  • minssh_salt_install_package
  • allcli_reboot
  • minssh_bootstrap_api
  • proxy_retail_pxeboot_and_mass_import
  • min_rhlike_salt_install_package_and_patch
  • min_deblike_monitoring
  • srv_wait_for_reposync
  • min_deblike_salt_install_with_staging
  • srv_sync_channels
  • min_check_patches_install
  • srv_user_configuration_salt_states
  • srv_scc_user_credentials
  • srv_cobbler_distro
  • min_rhlike_salt
  • min_salt_lock_packages
  • proxy_branch_network
  • min_bootstrap_api
  • minssh_ansible_control_node
  • srv_channels_add
  • srv_first_settings
  • allcli_action_chain
  • min_salt_formulas_advanced
  • srv_power_management
  • srv_clone_channel_npn
  • srv_create_activationkey
  • min_salt_user_states
  • allcli_config_channel
  • srv_sync_products
  • min_virthost
  • min_deblike_openscap_audit
  • min_action_chain
  • min_config_state_channel_subscriptions
  • buildhost_docker_auth_registry
  • srv_handle_software_channels_with_ISS_v2
  • min_timezone
  • buildhost_osimage_build_image
  • srv_manage_activationkey
  • srv_advanced_search
  • min_activationkey
  • allcli_software_channels
  • min_bootstrap_reactivation
  • srv_maintenance_windows
  • min_salt_pkgset_beacon
  • proxy_as_pod_basic_tests
  • buildhost_docker_build_image
  • sle_minion
  • min_deblike_ssh
  • min_salt_software_states
  • min_rhlike_ssh
  • minssh_action_chain
  • min_custom_pkg_download_endpoint
  • allcli_system_group
  • srv_manage_channels_page
  • min_bootstrap_ssh_key
  • min_retracted_patches
  • min_change_software_channel
  • srv_create_fake_channels
  • srv_create_fake_repositories
  • proxy_container
  • proxy_container_branch_network
  • minssh_tunnel
  • proxy_container_cobbler_pxeboot
  • srv_push_package
  • proxy_container_retail_pxeboot
  • proxy_container_retail_mass_import

Copy link
Member

@rjmateus rjmateus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbbayburt cbbayburt merged commit 8eb120b into uyuni-project:master Dec 9, 2024
22 checks passed
@cbbayburt cbbayburt deleted the bsc1233400 branch December 9, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants