feat: update bootstrap_dns_android #966

rurirei · 2021-05-04T02:50:23Z

this makes:

the bootstrap dialer on both network tcp or udp
the public number for alternative dialer

…em_dns_android.go

…rt/internet/system_dns_android_test.go

rurirei · 2021-05-04T06:50:53Z

@CalmLong opinion wanted.

CalmLong · 2021-05-04T07:06:51Z

是需要通过外部来更改 bootstrapDNS 吗

rurirei · 2021-05-04T07:08:12Z

@CalmLong thanks for approving. you can find a example in _test.go

CalmLong · 2021-05-04T07:17:45Z

只是这里是替换了 net.DefaultResolver，UseAlternativeBootstrapDNS 改为 UseCustomBootstrapDNS 会不会好一些

rurirei · 2021-05-04T07:21:32Z

@CalmLong the naming is referenced internet.UseAlternativeSystemDialer in system_dialer.go

CalmLong · 2021-05-04T07:25:35Z

ok

xiaokangwang · 2021-05-04T14:00:48Z

You can tell me in detail the root reason you are attempting this change.

What kind of environment you are using this in?

Are you using V2Ray as standalone program in Android, or as a library?

If you are using it as a standalone program, please provide full configure file.
If you are using it as a library, please provide a link of code.

What is the thing you are expecting, and what unexpected thing happened?

rurirei · 2021-05-04T14:02:12Z

a revert is done here.

xiaokangwang

OK，non-android platforms shouldn't be influence by this change now. I will merge this before next release.

xiaokangwang · 2021-05-04T14:43:34Z

a revert is done here.

You can tell me in detail the root reason you are attempting this change.

What kind of environment you are using this in?

Are you using V2Ray as standalone program in Android, or as a library?

If you are using it as a standalone program, please provide full configure file.
If you are using it as a library, please provide a link of code.

What is the thing you are expecting, and what unexpected thing happened?

xiaokangwang · 2021-05-04T14:44:15Z

I wants to know the exact reason you wants to make this change so that I can have a long term solution for you.

rurirei · 2021-05-04T14:48:35Z

I wants to know the exact reason you wants to make this change so that I can have a long term solution for you.

#966 (comment)

xiaokangwang · 2021-05-04T14:50:11Z

I wants to know the exact reason you wants to make this change so that I can have a long term solution for you.

#966 (comment)

This is what you have changed, not why you have changed it.

If you are using it as a standalone program, please provide full configure file.
If you are using it as a library, please provide a link of code.

What is your exact use case?

xiaokangwang · 2021-05-04T14:51:37Z

I wants to find a permanent solution to your problem, and add it to the to do list

rurirei · 2021-05-04T14:53:42Z

@xiaokangwang

as library (AndroidLibV2ray based)
i need to override the dns address "8.8.8.8:53", and make a custom dns resolver
i want to a method to make the custom dialer.Resolver without uses internet.UseAlternativeSystemDialer

xiaokangwang · 2021-05-04T14:58:25Z

@xiaokangwang

1. as library (AndroidLibV2ray based)

2. i need to override the dns address "8.8.8.8:53"

OK, I will work toward a permanent solution to your issue. Can you give me a link of your client. This can help me assign priority.

rurirei · 2021-05-04T15:10:10Z

@xiaokangwang in fact internet.UseAlternativeSystemDialer() is not necessary for AndroidLibV2ray (method fdConn in AndroidLibV2ray is not necessary for work). i need a method to make a custom systemDialer.Resolver only, rather than to override the systemDialer (what method fdConn do). the reverted "systemDNS for systemDialer" commits is what i really wanted.

you can kindly do solve the problem exists pastly. thanks.

xiaokangwang · 2021-05-04T15:17:45Z

@xiaokangwang in fact internet.UseAlternativeSystemDialer() is not necessary for AndroidLibV2ray (method fdConn in AndroidLibV2ray is not necessary for work). i need a method to make a custom systemDialer.Resolver only, rather than to override the systemDialer (what method fdConn do). the reverted "systemDNS for systemDialer" commits is what i really wanted.

you can kindly do solve the problem exists pastly. thanks.

You don't have to convert this to a draft.

I will merge this PR as a temporary solution. You can use this temporary solution today while I am working on a permanent one.

Please mark this PR as ready for review so that I can merge it.

xiaokangwang · 2021-05-04T15:20:43Z

Ok, I will merge this before the next release.

xiaokangwang · 2021-05-05T06:49:22Z

@rurirei I am sorry to inform you that because of some of the recent PR you have made to this repo. ( #852 #966 #852 #831 ) I have requested team member to consider your PR ineligible for merge by organization members. A review from the organization owner will be required to merge your further PR. This status may be waivered later.

You have repeatably sent Pull Request to upstream to get your code pass compilation without understanding the implication and consequence of such change.

I am committed to helping you with achieving what you want to do without compromising the code quality, standard, and objective of V2Ray.

rurirei · 2021-05-05T07:19:15Z

@xiaokangwang i'm sorry for bad codes.

xiaokangwang · 2021-05-05T07:25:20Z

@xiaokangwang i'm sorry for bad codes.

Don't worry, we have all been inexperienced at some point, and I have made a lot of mistakes in the past(and now) as well. It is not your fault. I just wants to reduce the revert action whenever possible.

But, I am here to help you! I can discuss your change with you and get things working together. Just make sure don't make any major change before asking, you might waste your time and I will feel really bad to request you to redo the work.

rurirei · 2021-05-05T07:28:31Z

I just wants to reduce the revert action whenever possible.

i'm glad to see your help of course.

p.s. what i did is just pull request, not commiting? 😢

xiaokangwang · 2021-05-05T07:29:55Z

Yes, but if someone else merged your code without the necessary review, I will have to revert it at a later point.

rurirei · 2021-05-05T07:32:24Z

got it. draft is the good idea.

xiaokangwang · 2021-05-05T07:35:10Z

And, you can request for review at any point. ^_^ I am ready when you are.

rurirei added 4 commits May 4, 2021 10:43

update with non_specified network

bbb1834

remove wrongs

602e34d

add alternative bootstrapDialer

de31ea3

do test

fbdf783

rurirei marked this pull request as draft May 4, 2021 03:08

rurirei added 10 commits May 4, 2021 11:21

Update dns_bootstrap_android_test.go

c7158f4

example of alternative dialer

35ffcd2

public method

2bf158f

move const

6dc353f

Update dns_bootstrap_android_test.go

60a043e

no duplicated

90d5a29

Rename infra/conf/dns_bootstrap_android.go to transport/internet/syst…

1c12258

…em_dns_android.go

Update system_dns_android.go

995f793

Update and rename infra/conf/dns_bootstrap_android_test.go to transpo…

aba9fbd

…rt/internet/system_dns_android_test.go

no imports

88f0302

rurirei marked this pull request as ready for review May 4, 2021 03:53

rurirei changed the title ~~feat: update bootstrapdns with network~~ feat: update bootstrap_dns_android May 4, 2021

rurirei added 2 commits May 4, 2021 14:56

Update system_dns_android.go

33b6d12

Update system_dns_android_test.go

2555128

CalmLong approved these changes May 4, 2021

View reviewed changes

rurirei marked this pull request as draft May 4, 2021 09:02

rurirei added 3 commits May 4, 2021 17:13

create systemDNS

b98f06d

Create system_dns_android.go

066a1eb

Update system_dialer.go

02c1267

typo

f7903f2

rurirei changed the title ~~feat&refine: systemDNS for systemDialer~~ feat: update bootstrap_dns_android May 4, 2021

rurirei marked this pull request as ready for review May 4, 2021 14:28

xiaokangwang approved these changes May 4, 2021

View reviewed changes

rurirei marked this pull request as draft May 4, 2021 15:11

rurirei marked this pull request as ready for review May 4, 2021 15:18

rurirei mentioned this pull request May 4, 2021

feat: update bootstrap_dns_android 2 #970

Closed

xiaokangwang merged commit 2129c6e into v2fly:master May 4, 2021

WaterLemons2k mentioned this pull request Apr 19, 2023

feat: custom DNS server jeessy2/ddns-go#682

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update bootstrap_dns_android #966

feat: update bootstrap_dns_android #966

rurirei commented May 4, 2021 •

edited

Loading

rurirei commented May 4, 2021

CalmLong commented May 4, 2021

rurirei commented May 4, 2021

CalmLong commented May 4, 2021

rurirei commented May 4, 2021

CalmLong commented May 4, 2021

xiaokangwang commented May 4, 2021

rurirei commented May 4, 2021

xiaokangwang left a comment •

edited

Loading

xiaokangwang commented May 4, 2021

xiaokangwang commented May 4, 2021

rurirei commented May 4, 2021

xiaokangwang commented May 4, 2021

xiaokangwang commented May 4, 2021

rurirei commented May 4, 2021 •

edited

Loading

xiaokangwang commented May 4, 2021

rurirei commented May 4, 2021 •

edited

Loading

xiaokangwang commented May 4, 2021 •

edited

Loading

xiaokangwang commented May 4, 2021 •

edited

Loading

xiaokangwang commented May 5, 2021

rurirei commented May 5, 2021

xiaokangwang commented May 5, 2021 •

edited

Loading

rurirei commented May 5, 2021

xiaokangwang commented May 5, 2021

rurirei commented May 5, 2021

xiaokangwang commented May 5, 2021

feat: update bootstrap_dns_android #966

feat: update bootstrap_dns_android #966

Conversation

rurirei commented May 4, 2021 • edited Loading

rurirei commented May 4, 2021

CalmLong commented May 4, 2021

rurirei commented May 4, 2021

CalmLong commented May 4, 2021

rurirei commented May 4, 2021

CalmLong commented May 4, 2021

xiaokangwang commented May 4, 2021

rurirei commented May 4, 2021

xiaokangwang left a comment • edited Loading

Choose a reason for hiding this comment

xiaokangwang commented May 4, 2021

xiaokangwang commented May 4, 2021

rurirei commented May 4, 2021

xiaokangwang commented May 4, 2021

xiaokangwang commented May 4, 2021

rurirei commented May 4, 2021 • edited Loading

xiaokangwang commented May 4, 2021

rurirei commented May 4, 2021 • edited Loading

xiaokangwang commented May 4, 2021 • edited Loading

xiaokangwang commented May 4, 2021 • edited Loading

xiaokangwang commented May 5, 2021

rurirei commented May 5, 2021

xiaokangwang commented May 5, 2021 • edited Loading

rurirei commented May 5, 2021

xiaokangwang commented May 5, 2021

rurirei commented May 5, 2021

xiaokangwang commented May 5, 2021

rurirei commented May 4, 2021 •

edited

Loading

xiaokangwang left a comment •

edited

Loading

rurirei commented May 4, 2021 •

edited

Loading

rurirei commented May 4, 2021 •

edited

Loading

xiaokangwang commented May 4, 2021 •

edited

Loading

xiaokangwang commented May 4, 2021 •

edited

Loading

xiaokangwang commented May 5, 2021 •

edited

Loading