Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Designer in Eclipse can not handle frontend directory in different location with Lit components #2434

Closed
lordmikefin opened this issue Mar 22, 2022 · 6 comments
Assignees
Labels
BFP Warranty prioritised issue

Comments

@lordmikefin
Copy link

When 'frontend' directory is moved, then Designer can not handle Lit component within Lit component.
NOTE: Designer does not have same problem with Polymer components.

Steps to reproduce

My sample project:
skeleton-starter-flow-spring-frontend-moved.zip

  1. Clone vaadin 14 starter project
    git clone https://github.com/vaadin/skeleton-starter-flow-spring.git
    cd skeleton-starter-flow-spring
    git checkout v14
  2. Rename 'frontend' direcotry to 'frontend-moved'
    git mv frontend frontend-moved
  3. Change frontend directory. Edit maven project file 'pom.xml'.
    Add 'frontendDirectory' -configuration
    <configuration>
        <frontendDirectory>${project.basedir}/frontend-moved</frontendDirectory>
    </configuration>
    
    Into 'vaadin-maven-plugin' in 'plugin' section.
    NOTE: The 'vaadin-maven-plugin' is in two sections 'build' and 'profiles'.
    End result sample:
        <plugin>
            <groupId>com.vaadin</groupId>
            <artifactId>vaadin-maven-plugin</artifactId>
            <version>${vaadin.version}</version>
            <configuration>
                <frontendDirectory>${project.basedir}/frontend-moved</frontendDirectory>
            </configuration>
        </plugin>
    
  4. Import into Eclipse IDE
  5. Create new Lit component 'lit-test-child'
  6. Create new Lit component 'lit-test-parent'
  7. Drag&Drop 'lit-test-child' into 'lit-test-parent'

Actual behavior

Designer does not show any content for child Lit component.

If "lit-test-parent" is reopened, then just white canvas is shown.
No content at all :(

Expected behavior

Designer should show 'lit-test-child' componet content within the 'lit-test-parent' component view.

IDE, Designer and OS version

IDE Designer Vaadin OS
Eclipse 2021-12 4.6.14 14.8.6 Windows
@Theikk
Copy link

Theikk commented Mar 25, 2022

Problem behavior can be repeated on V23 as well.

IDE Designer Vaadin OS
Version: 2019-09 R (4.13.0) 4.6.15 23.0.2 Windows 10

@caalador caalador added the BFP Warranty prioritised issue label Mar 25, 2022
@anssit
Copy link
Contributor

anssit commented Mar 25, 2022

Confirmed: GET http://localhost:52962/project/frontend-moved/src/lit-test-child net::ERR_ABORTED 404 (Not Found)

@anssit
Copy link
Contributor

anssit commented Mar 25, 2022

Problem also with IntelliJ IDEA

@mshabarov
Copy link

@szolo could you please give a status of this issue? Do we have a patch?

@szolo
Copy link
Contributor

szolo commented Jun 28, 2022

Hello, new Designer version with a fix for this issue will be released soon. Designer will provide an option to specify any folder as a frontend folder via preferences. Thanks!

@szolo
Copy link
Contributor

szolo commented Jul 25, 2022

Hello @lordmikefin, we have just released Vaadin Designer 4.6.18.

There is a new preference setting "Front Folder" under "Vaadin Designer" preferences. Feel free to change it according to your needs. By default it is "frontend".

img

@szolo szolo closed this as completed Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFP Warranty prioritised issue
Projects
None yet
Development

No branches or pull requests

6 participants