From 5214dce404b0eb8684909dcad17922b0a7305bde Mon Sep 17 00:00:00 2001 From: Artur Signell Date: Thu, 19 Sep 2024 15:19:14 +0300 Subject: [PATCH] fix: Do not throw if re-setting the login view Fixes #19910 --- .../vaadin/flow/server/auth/NavigationAccessControl.java | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/flow-server/src/main/java/com/vaadin/flow/server/auth/NavigationAccessControl.java b/flow-server/src/main/java/com/vaadin/flow/server/auth/NavigationAccessControl.java index 4f76c095d1a..a33042392f8 100644 --- a/flow-server/src/main/java/com/vaadin/flow/server/auth/NavigationAccessControl.java +++ b/flow-server/src/main/java/com/vaadin/flow/server/auth/NavigationAccessControl.java @@ -187,6 +187,10 @@ public final boolean isEnabled() { * the Flow view to use as login view */ public final void setLoginView(Class loginView) { + if (loginView == this.loginView) { + // Probably hot reload + return; + } throwIfLoginViewSet(); this.loginView = loginView; } @@ -210,6 +214,11 @@ protected Class getLoginView() { * the frontend view to use as login view */ public void setLoginView(String loginUrl) { + if (loginUrl == this.loginUrl) { + // Probably hot reload + return; + } + throwIfLoginViewSet(); this.loginUrl = loginUrl; }