New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AttachEvent and DetachEvent are in ui.common, while most of the other events are in ui.event #2655

Closed

samie opened this issue Oct 11, 2017 · 0 comments

Labels

breaking change bug Good First Issue

Milestone

Member

samie commented Oct 11, 2017

When importing classes the AttachEvent and DetachEvent imports look inconsistent with other similar events:
https://github.com/vaadin/flow/blob/master/flow-server/src/main/java/com/vaadin/ui/common/AttachEvent.java
https://github.com/vaadin/flow/blob/master/flow-server/src/main/java/com/vaadin/ui/common/DetachEvent.java

Would expect to find them with other events:
https://github.com/vaadin/flow/tree/master/flow-server/src/main/java/com/vaadin/ui/event

pleku added bug Good First Issue breaking change labels

heruan mentioned this issue

Move AttachEvent and DetachEvent to com.vaadin.ui.event #2717

Merged

SomeoneToIgnore closed this as completed in #2717

SomeoneToIgnore added this to the 1.0.0.alpha6 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment