I18N: VaadinSession.setLocale() doesn't update locales for UIs

[denis-anisimov]

I'm not sure whether this is a bug or not but I would expect that
the locale is updated being set to the VaadinSession instance for the all active UIs.

If I don't want to update locales for all UIs I use UI::setLocale only for specific UIs.

[Legioth]

Maybe just remove the method?

[denis-anisimov]

I'm OK with that.

But I think it's used in the impl.
When the new UI is created it gets the Locale from the session :

protected UI createAndInitUI(Class<? extends UI> uiClass,
            VaadinRequest request, VaadinSession session) {
        UI ui = ReflectTools.createInstance(uiClass);

        // Initialize some fields for a newly created UI
        ui.getInternals().setSession(session);
        ui.setLocale(session.getLocale());

[Legioth]

It uses the getter, but not the setter.

[denis-anisimov]

But the setter is apparently used in another place to set the Locale for the session.
Or it's final /initialized inside the session?

[caalador]

The session could do the initialisation of the locale by itself. VaadinService could for instance call VaadinSession.initializeLocale(I18NProvider) then we wouldn't need to have a setLocale in 2 places. But then perhaps the getter should be renamed to getInitialLocale ?

[caalador]

Or just have in the UI init the locale on doInit(VaadinRequest request, int uiId) that is called on createAndInitUI from the BootstrapHandler.
Or should we remove the set from UI and only have it used from VaadinSession?