Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX: As a plugin user, I want to be able to specify fragment names #3318

Closed
SomeoneToIgnore opened this issue Jan 16, 2018 · 0 comments
Closed

Comments

@SomeoneToIgnore
Copy link
Contributor

@SomeoneToIgnore commented on Wed Jan 10 2018

When bundling, I want to separate everything related to Grid to a bundle, and specify a name to it so that I can know when it is loaded

Currently fragment names are discarded if specified in Maven configuration and are missing from json configuration.

We should provide a way to specify the name in both and to use that name in bundling later (create fragment files with that name).
If no name specified, we should either provide the default or fail.

What needs to be done:

  • change json structure to accept names
  • refactor the logic so that xml and json configurations are processed by a separate class, write tests on it
  • create the files with the actual names
  • update the documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants