From ee04eb6c2df0e61d608af9df3f1e6d095c1a1d76 Mon Sep 17 00:00:00 2001 From: Kirill Bulatov Date: Wed, 18 Oct 2017 19:53:45 +0300 Subject: [PATCH 1/4] Use webjars bom. --- .../demo-flow-components/pom.xml | 50 ++- .../flow-components/pom.xml | 285 +++++-------- pom.xml | 304 +++----------- webjars-bom/pom.xml | 379 ++++++++++++++++++ 4 files changed, 576 insertions(+), 442 deletions(-) create mode 100644 webjars-bom/pom.xml diff --git a/flow-components-parent/demo-flow-components/pom.xml b/flow-components-parent/demo-flow-components/pom.xml index 6944d318822..ab192adb76a 100644 --- a/flow-components-parent/demo-flow-components/pom.xml +++ b/flow-components-parent/demo-flow-components/pom.xml @@ -37,60 +37,82 @@ org.webjars.bower paper-styles + + + + org.webjars.bower + paper-button 2.0.0 org.webjars.bower - paper-item + paper-input + + + + org.webjars.bower + paper-spinner 2.0.0 org.webjars.bower - github-com-polymerelements-paper-ripple + github-com-polymerelements-paper-card + 2.0.0 org.webjars.bower - iron-collapse + paper-progress + + + + org.webjars.bower + paper-dialog 2.0.0 org.webjars.bower - iron-icon - 2.0.1 + web-animations-js + 2.2.5 org.webjars.bower - iron-icons + paper-swatch-picker 2.0.1 org.webjars.bower - vaadin-split-layout - 3.0.0-beta1 + app-layout + 2.0.2 org.webjars.bower - vaadin-dialog - 1.0.0-beta1 + paper-item + 2.0.0 org.webjars.bower - vaadin-icons - 4.1.2 + github-com-polymerelements-paper-ripple + 2.0.1 org.webjars.bower - vaadin-valo-theme - 0.3.2 + iron-collapse + 2.0.0 + + + + org.webjars.bower + iron-icons + 2.0.1 diff --git a/flow-components-parent/flow-components/pom.xml b/flow-components-parent/flow-components/pom.xml index 2327713048d..58bc449f7d4 100644 --- a/flow-components-parent/flow-components/pom.xml +++ b/flow-components-parent/flow-components/pom.xml @@ -1,186 +1,99 @@ - - - 4.0.0 - - com.vaadin - flow-components-parent - 1.0-SNAPSHOT - - flow-components - Flow server side components - jar - - - - - com.vaadin - flow-generated-components - ${project.version} - - - com.vaadin - flow-html-components - - - com.vaadin - flow-data - test - test-jar - ${project.version} - - - javax.validation - validation-api - 2.0.0.Final - - - javax.servlet - javax.servlet-api - test - - - org.hibernate.validator - hibernate-validator - ${hibernate.validator.version} - test - - - - - org.webjars.bower - polymer - - - - org.webjars.bower - paper-button - 2.0.0 - - - - org.webjars.bower - paper-input - 2.0.2 - - - - org.webjars.bower - paper-spinner - 2.0.0 - - - - org.webjars.bower - github-com-polymerelements-paper-card - 2.0.0 - - - - org.webjars.bower - paper-progress - 2.0.1 - - - - org.webjars.bower - paper-dialog - 2.0.0 - - - - org.webjars.bower - neon-animation - 2.0.1 - - - - org.webjars.bower - web-animations-js - 2.2.5 - - - - org.webjars.bower - paper-swatch-picker - 2.0.1 - - - - org.webjars.bower - app-layout - 2.0.2 - - - - org.webjars.bower - iron-flex-layout - 2.0.0 - - - - org.webjars.bower - iron-iconset-svg - 2.1.0 - - - - org.webjars.bower - iron-media-query - 2.0.0 - - - - org.webjars.bower - iron-selector - 2.0.0 - - - - org.webjars.bower - vaadin-grid - 4.0.0-alpha4 - - - - org.webjars.bower - vaadin-text-field - 1.1.0-beta1 - - - - org.webjars.bower - vaadin-date-picker - 2.0.5 - - - - org.webjars.bower - vaadin-button - 1.0.4 - - - - org.webjars.bower - vaadin-checkbox - - - - org.webjars.bower - vaadin-combo-box - 3.0.0-beta1 - - - - org.webjars.bower - vaadin-form-layout - 1.0.3 - - - - org.webjars.bower - vaadin-ordered-layout - 1.0.0-alpha1 - - - + + + 4.0.0 + + com.vaadin + flow-components-parent + 1.0-SNAPSHOT + + flow-components + Flow server side components + jar + + + + + com.vaadin + flow-generated-components + ${project.version} + + + com.vaadin + flow-html-components + + + com.vaadin + flow-data + test + test-jar + ${project.version} + + + javax.validation + validation-api + 2.0.0.Final + + + javax.servlet + javax.servlet-api + test + + + org.hibernate.validator + hibernate-validator + ${hibernate.validator.version} + test + + + + + org.webjars.bower + vaadin-grid + + + org.webjars.bower + vaadin-icons + + + org.webjars.bower + vaadin-text-field + + + org.webjars.bower + vaadin-date-picker + + + org.webjars.bower + vaadin-button + + + org.webjars.bower + vaadin-dialog + + + org.webjars.bower + vaadin-combo-box + + + org.webjars.bower + vaadin-form-layout + + + org.webjars.bower + vaadin-checkbox + + + org.webjars.bower + vaadin-split-layout + + + org.webjars.bower + vaadin-ordered-layout + + + org.webjars.bower + vaadin-valo-theme + + + diff --git a/pom.xml b/pom.xml index f7b8390f786..8916173e09e 100644 --- a/pom.xml +++ b/pom.xml @@ -1,6 +1,7 @@ - + 4.0.0 com.vaadin @@ -10,6 +11,7 @@ 1.0-SNAPSHOT + webjars-bom flow flow-server flow-push @@ -40,24 +42,32 @@ 2000 scm:https:https://github.com/vaadin/flow.git - scm:git:git@github.com:vaadin/flow.git + scm:git:git@github.com:vaadin/flow.git + https://github.com/vaadin/flow hummingbird-snapshot - https://repo.vaadin.com/nexus/content/repositories/flow-snapshots/ - https://repo.vaadin.com/nexus/content/repositories/flow/ - ${flow.snapshot.repo.url} + + https://repo.vaadin.com/nexus/content/repositories/flow-snapshots/ + + + https://repo.vaadin.com/nexus/content/repositories/flow/ + + ${flow.snapshot.repo.url} + 1.8 1.8 UTF-8 - UTF-8 + UTF-8 + 1.0.1 8 preview - true + true + true true false @@ -67,7 +77,8 @@ 6.0.1.Final - 1.0.14 + 1.0.14 + 1.5 2.20 2.20 @@ -124,11 +135,6 @@ - - com.google.gwt - gwt-elemental - ${gwt.version} - com.google.jsinterop jsinterop @@ -136,6 +142,19 @@ pom import + + com.vaadin + vaadin-webjars-bom + pom + import + ${project.version} + + + + com.google.gwt + gwt-elemental + ${gwt.version} + junit junit @@ -179,113 +198,24 @@ 2.0 - - - org.webjars.bower - polymer - 2.0.2 - - - org.webjars.bower - github-com-polymer-polymer - v2.0.2 - - + org.webjars.bower - vaadin-checkbox - 1.0.0-beta1 - - - - org.webjars.bower - github-com-polymerelements-paper-input - 2.0.2 - - - - org.webjars.bower - github-com-polymerelements-paper-progress - 2.0.1 - - - - org.webjars.bower - github-com-polymerelements-iron-meta - 2.0.2 - - - - org.webjars.bower - github-com-vaadin-vaadin-control-state-mixin - v1.1.4 - - - - org.webjars.bower - github-com-webcomponents-shadycss - v1.0.6 - - - - org.webjars.bower - webcomponentsjs - 1.0.14 - - - - org.webjars.bower - github-com-polymerelements-iron-checked-element-behavior + paper-styles 2.0.0 - org.webjars.bower github-com-polymerelements-paper-styles 2.0.0 - - org.webjars.bower - github-com-polymerelements-paper-behaviors - 2.0.0 - - - - org.webjars.bower - github-com-polymerelements-iron-flex-layout - 2.0.0 - - - - org.webjars.bower - github-com-polymerelements-paper-ripple - 2.0.1 - - org.webjars.bower github-com-polymerelements-font-roboto 1.0.3 - - org.webjars.bower - github-com-polymerelements-iron-a11y-keys-behavior - 2.0.1 - - - org.webjars.bower - iron-a11y-keys-behavior - 2.0.1 - - - - org.webjars.bower - github-com-polymerelements-iron-behaviors - 2.0.0 - - org.webjars.bower github-com-polymerelements-iron-autogrow-textarea @@ -295,7 +225,7 @@ org.webjars.bower github-com-polymerelements-iron-validatable-behavior - 2.0.0 + 1.1.1 @@ -306,71 +236,47 @@ org.webjars.bower - github-com-polymerelements-iron-a11y-announcer - 2.0.0 - - - org.webjars.bower - iron-a11y-announcer - 2.0.0 - - - - org.webjars.bower - github-com-polymerelements-paper-dialog-behavior - 2.0.1 + github-com-polymerelements-iron-form-element-behavior + 1.0.6 org.webjars.bower - github-com-polymerelements-iron-overlay-behavior - 2.0.0 - - - org.webjars.bower - iron-overlay-behavior - 2.0.0 + paper-input + 2.0.2 - org.webjars.bower - github-com-polymerelements-iron-fit-behavior - 2.0.1 + github-com-polymerelements-paper-input + 2.0.2 org.webjars.bower - github-com-polymerelements-iron-resizable-behavior + paper-progress 2.0.1 org.webjars.bower - iron-resizable-behavior + github-com-polymerelements-paper-progress 2.0.1 org.webjars.bower - github-com-polymerelements-paper-item + github-com-polymerelements-iron-range-behavior 2.0.0 - - - org.webjars.bower - github-com-polymerelements-marked-element - 2.3.0 - - org.webjars.bower - github-com-polymerelements-prism-element - 2.0.1 + github-com-polymerelements-paper-behaviors + 1.0.10 org.webjars.bower - github-com-polymerelements-iron-form-element-behavior + github-com-PolymerElements-iron-checked-element-behavior 2.0.0 @@ -382,25 +288,18 @@ org.webjars.bower - github-com-polymerelements-iron-range-behavior - 2.0.0 - - - - org.webjars.bower - github-com-polymerelements-neon-animation + github-com-polymerelements-paper-dialog-behavior 2.0.1 org.webjars.bower - github-com-polymerelements-iron-selector + paper-item 2.0.0 - org.webjars.bower - github-com-polymerelements-iron-scroll-target-behavior + github-com-polymerelements-paper-item 2.0.0 @@ -410,36 +309,12 @@ 2.0.1 - - org.webjars.bower - github-com-polymerelements-iron-iconset-svg - 2.1.0 - - org.webjars.bower github-com-polymerelements-paper-listbox 2.0.0 - - org.webjars.bower - github-com-polymerelements-paper-menu-button - 2.0.0 - - - - org.webjars.bower - github-com-polymerelements-iron-media-query - 2.0.0 - - - - org.webjars.bower - github-com-polymerelements-iron-icon - 2.0.1 - - org.webjars.bower github-com-polymerelements-iron-menu-behavior @@ -448,69 +323,9 @@ org.webjars.bower - github-com-polymerelements-iron-dropdown - 2.0.0 - - - org.webjars.bower - iron-dropdown + github-com-polymerelements-paper-menu-button 2.0.0 - - - org.webjars.bower - vaadin-themable-mixin - 1.1.3 - - - - org.webjars.bower - vaadin-control-state-mixin - 1.1.4 - - - - org.webjars.bower - iron-list - 2.0.8 - - - - org.webjars.bower - vaadin-overlay - 1.4.1 - - - - - org.webjars.bower - vaadin-demo-helpers - 1.0.0 - - - - org.webjars.bower - marked - 0.3.6 - - - - org.webjars.bower - prism - 1.8.1 - - - - org.webjars.bower - github-com-polymerelements-app-route - 2.0.2 - - - - org.webjars.bower - github-com-polymerelements-iron-location - 2.0.1 - @@ -561,9 +376,11 @@ formatter-maven-plugin 1.8.1 - classpath:/eclipse/VaadinJavaConventions.xml + classpath:/eclipse/VaadinJavaConventions.xml + - classpath:/eclipse/VaadinJavaConventions.xml + classpath:/eclipse/VaadinJavaConventions.xml + @@ -651,7 +468,8 @@ ${project.rootdir}/driver - ${project.rootdir}/driver_zips + ${project.rootdir}/driver_zips + error-screenshots @@ -674,8 +492,10 @@ - ${project.name} - ${project.version} + ${project.name} + + ${project.version} + diff --git a/webjars-bom/pom.xml b/webjars-bom/pom.xml new file mode 100644 index 00000000000..c1bb327701a --- /dev/null +++ b/webjars-bom/pom.xml @@ -0,0 +1,379 @@ + + 4.0.0 + com.vaadin + vaadin-webjars-bom + pom + 1.0-SNAPSHOT + Vaadin Webjars (Bill of Materials) + Vaadin Webjars (Bill of Materials) + + + + + + org.webjars.bower + vaadin-grid + 4.0.0-alpha4 + + + org.webjars.bower + vaadin-icons + 4.1.3 + + + org.webjars.bower + vaadin-text-field + 1.1.0 + + + org.webjars.bower + vaadin-date-picker + 2.0.5 + + + org.webjars.bower + vaadin-button + 1.0.4 + + + org.webjars.bower + vaadin-dialog + 1.0.0 + + + org.webjars.bower + vaadin-combo-box + 3.0.0 + + + org.webjars.bower + vaadin-form-layout + 1.0.3 + + + org.webjars.bower + vaadin-checkbox + 1.0.0 + + + org.webjars.bower + vaadin-split-layout + 3.0.0 + + + org.webjars.bower + vaadin-ordered-layout + 1.0.0-alpha1 + + + org.webjars.bower + vaadin-valo-theme + 2.0.0-alpha3 + + + + + org.webjars.bower + polymer + 2.1.1 + + + org.webjars.bower + github-com-polymer-polymer + v2.1.1 + + + org.webjars.bower + github-com-Polymer-polymer + v2.1.1 + + + + org.webjars.bower + github-com-webcomponents-shadycss + v1.0.6 + + + org.webjars.bower + shadycss + 1.0.6 + + + org.webjars.bower + webcomponentsjs + 1.0.14 + + + org.webjars.bower + github-com-webcomponents-webcomponentsjs + v1.0.14 + + + org.webjars.bower + vaadin-control-state-mixin + 1.1.5 + + + org.webjars.bower + github-com-vaadin-vaadin-control-state-mixin + v1.1.5 + + + org.webjars.bower + vaadin-themable-mixin + 1.1.5 + + + org.webjars.bower + github-com-vaadin-vaadin-themable-mixin + v1.1.5 + + + org.webjars.bower + vaadin-overlay + 1.4.1 + + + org.webjars.bower + github-com-vaadin-vaadin-overlay + v1.4.1 + + + org.webjars.bower + iron-a11y-announcer + 2.0.0 + + + org.webjars.bower + github-com-polymerelements-iron-a11y-announcer + 2.0.0 + + + org.webjars.bower + github-com-PolymerElements-iron-a11y-announcer + 2.0.0 + + + org.webjars.bower + iron-a11y-keys-behavior + 2.0.1 + + + org.webjars.bower + github-com-polymerelements-iron-a11y-keys-behavior + 2.0.1 + + + org.webjars.bower + github-com-PolymerElements-iron-a11y-keys-behavior + 2.0.1 + + + org.webjars.bower + iron-resizable-behavior + 2.0.1 + + + org.webjars.bower + github-com-polymerelements-iron-resizable-behavior + 2.0.1 + + + org.webjars.bower + github-com-PolymerElements-iron-resizable-behavior + 2.0.1 + + + org.webjars.bower + iron-list + 2.0.10 + + + org.webjars.bower + github-com-polymerelements-iron-list + v2.0.10 + + + org.webjars.bower + github-com-PolymerElements-iron-list + v2.0.10 + + + org.webjars.bower + github-com-polymerelements-iron-scroll-target-behavior + 2.0.0 + + + org.webjars.bower + github-com-PolymerElements-iron-scroll-target-behavior + 2.0.0 + + + org.webjars.bower + iron-scroll-target-behavior + 2.0.0 + + + org.webjars.bower + iron-icon + 2.0.1 + + + org.webjars.bower + github-com-polymerelements-iron-icon + 2.0.1 + + + org.webjars.bower + github-com-PolymerElements-iron-icon + 2.0.1 + + + org.webjars.bower + github-com-polymerelements-iron-meta + 2.0.2 + + + org.webjars.bower + github-com-PolymerElements-iron-meta + 2.0.2 + + + org.webjars.bower + iron-selector + 2.0.0 + + + org.webjars.bower + github-com-polymerelements-iron-selector + 2.0.0 + + + org.webjars.bower + github-com-PolymerElements-iron-selector + 2.0.0 + + + org.webjars.bower + iron-overlay-behavior + 2.1.0 + + + org.webjars.bower + github-com-polymerelements-iron-overlay-behavior + 2.1.0 + + + org.webjars.bower + github-com-PolymerElements-iron-overlay-behavior + 2.1.0 + + + org.webjars.bower + iron-iconset-svg + 2.1.0 + + + org.webjars.bower + github-com-polymerelements-iron-iconset-svg + 2.1.0 + + + org.webjars.bower + github-com-PolymerElements-iron-iconset-svg + 2.1.0 + + + org.webjars.bower + iron-dropdown + 2.0.0 + + + org.webjars.bower + github-com-polymerelements-iron-dropdown + 2.0.0 + + + org.webjars.bower + github-com-PolymerElements-iron-dropdown + 2.0.0 + + + org.webjars.bower + iron-behaviors + 2.0.0 + + + org.webjars.bower + github-com-polymerelements-iron-behaviors + 2.0.0 + + + org.webjars.bower + github-com-PolymerElements-iron-behaviors + 2.0.0 + + + org.webjars.bower + neon-animation + 2.0.1 + + + org.webjars.bower + github-com-polymerelements-neon-animation + 2.0.1 + + + org.webjars.bower + github-com-PolymerElements-neon-animation + 2.0.1 + + + org.webjars.bower + iron-media-query + 2.0.0 + + + org.webjars.bower + github-com-polymerelements-iron-media-query + 2.0.0 + + + org.webjars.bower + github-com-PolymerElements-iron-media-query + 2.0.0 + + + org.webjars.bower + iron-flex-layout + 2.0.0 + + + org.webjars.bower + github-com-polymerelements-iron-flex-layout + 2.0.0 + + + org.webjars.bower + github-com-PolymerElements-iron-flex-layout + 2.0.0 + + + org.webjars.bower + iron-fit-behavior + 2.0.1 + + + org.webjars.bower + github-com-polymerelements-iron-fit-behavior + 2.0.1 + + + org.webjars.bower + github-com-PolymerElements-iron-fit-behavior + 2.0.1 + + + + From a4315220db5b37e3943d2512d5051549760eb426 Mon Sep 17 00:00:00 2001 From: Giovanni Lovato Date: Wed, 18 Oct 2017 21:21:32 +0200 Subject: [PATCH 2/4] Move Transport class to com.vaadin.shared.ui (#2716) --- .../java/com/vaadin/flow/nodefeature/PushConfigurationMap.java | 2 +- .../src/main/java/com/vaadin/shared/ui/{ui => }/Transport.java | 2 +- flow-server/src/main/java/com/vaadin/ui/Push.java | 2 +- flow-server/src/main/java/com/vaadin/ui/PushConfiguration.java | 2 +- flow-server/src/main/java/com/vaadin/util/AnnotationReader.java | 2 +- .../com/vaadin/flow/nodefeature/PushConfigurationMapTest.java | 2 +- .../com/vaadin/flow/uitest/ui/push/BasicPushLongPollingUI.java | 2 +- .../com/vaadin/flow/uitest/ui/push/BasicPushWebsocketUI.java | 2 +- .../com/vaadin/flow/uitest/ui/push/BasicPushWebsocketXhrUI.java | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) rename flow-server/src/main/java/com/vaadin/shared/ui/{ui => }/Transport.java (98%) diff --git a/flow-server/src/main/java/com/vaadin/flow/nodefeature/PushConfigurationMap.java b/flow-server/src/main/java/com/vaadin/flow/nodefeature/PushConfigurationMap.java index 55b6f1e2130..b268be9623a 100644 --- a/flow-server/src/main/java/com/vaadin/flow/nodefeature/PushConfigurationMap.java +++ b/flow-server/src/main/java/com/vaadin/flow/nodefeature/PushConfigurationMap.java @@ -19,7 +19,7 @@ import com.vaadin.flow.StateNode; import com.vaadin.shared.communication.PushMode; -import com.vaadin.shared.ui.ui.Transport; +import com.vaadin.shared.ui.Transport; import com.vaadin.ui.PushConfiguration; /** diff --git a/flow-server/src/main/java/com/vaadin/shared/ui/ui/Transport.java b/flow-server/src/main/java/com/vaadin/shared/ui/Transport.java similarity index 98% rename from flow-server/src/main/java/com/vaadin/shared/ui/ui/Transport.java rename to flow-server/src/main/java/com/vaadin/shared/ui/Transport.java index 4505ba3b4cb..d34fcddb22e 100644 --- a/flow-server/src/main/java/com/vaadin/shared/ui/ui/Transport.java +++ b/flow-server/src/main/java/com/vaadin/shared/ui/Transport.java @@ -14,7 +14,7 @@ * the License. */ -package com.vaadin.shared.ui.ui; +package com.vaadin.shared.ui; /** * Transport modes for Push diff --git a/flow-server/src/main/java/com/vaadin/ui/Push.java b/flow-server/src/main/java/com/vaadin/ui/Push.java index 61d56f102ef..f9894e33f28 100644 --- a/flow-server/src/main/java/com/vaadin/ui/Push.java +++ b/flow-server/src/main/java/com/vaadin/ui/Push.java @@ -22,7 +22,7 @@ import java.lang.annotation.Target; import com.vaadin.shared.communication.PushMode; -import com.vaadin.shared.ui.ui.Transport; +import com.vaadin.shared.ui.Transport; import com.vaadin.ui.UI; /** diff --git a/flow-server/src/main/java/com/vaadin/ui/PushConfiguration.java b/flow-server/src/main/java/com/vaadin/ui/PushConfiguration.java index 7993f16a5ff..ec4b4eb8e8b 100644 --- a/flow-server/src/main/java/com/vaadin/ui/PushConfiguration.java +++ b/flow-server/src/main/java/com/vaadin/ui/PushConfiguration.java @@ -23,7 +23,7 @@ import com.vaadin.server.VaadinSession; import com.vaadin.server.communication.AtmospherePushConnection; import com.vaadin.shared.communication.PushMode; -import com.vaadin.shared.ui.ui.Transport; +import com.vaadin.shared.ui.Transport; /** * Provides method for configuring the push channel. diff --git a/flow-server/src/main/java/com/vaadin/util/AnnotationReader.java b/flow-server/src/main/java/com/vaadin/util/AnnotationReader.java index 494caae50eb..598ff45a45c 100644 --- a/flow-server/src/main/java/com/vaadin/util/AnnotationReader.java +++ b/flow-server/src/main/java/com/vaadin/util/AnnotationReader.java @@ -29,7 +29,7 @@ import com.vaadin.router.PageTitle; import com.vaadin.flow.router.View; import com.vaadin.shared.communication.PushMode; -import com.vaadin.shared.ui.ui.Transport; +import com.vaadin.shared.ui.Transport; import com.vaadin.ui.Component; import com.vaadin.ui.UI; diff --git a/flow-server/src/test/java/com/vaadin/flow/nodefeature/PushConfigurationMapTest.java b/flow-server/src/test/java/com/vaadin/flow/nodefeature/PushConfigurationMapTest.java index cf633c032fc..d612f8588fc 100644 --- a/flow-server/src/test/java/com/vaadin/flow/nodefeature/PushConfigurationMapTest.java +++ b/flow-server/src/test/java/com/vaadin/flow/nodefeature/PushConfigurationMapTest.java @@ -7,7 +7,7 @@ import org.junit.Test; import com.vaadin.flow.nodefeature.PushConfigurationMap; -import com.vaadin.shared.ui.ui.Transport; +import com.vaadin.shared.ui.Transport; public class PushConfigurationMapTest extends AbstractNodeFeatureTest { diff --git a/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/push/BasicPushLongPollingUI.java b/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/push/BasicPushLongPollingUI.java index da3f46f4661..70488fe17f4 100644 --- a/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/push/BasicPushLongPollingUI.java +++ b/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/push/BasicPushLongPollingUI.java @@ -3,7 +3,7 @@ import com.vaadin.ui.Push; import com.vaadin.flow.nodefeature.PushConfigurationMap; import com.vaadin.server.VaadinRequest; -import com.vaadin.shared.ui.ui.Transport; +import com.vaadin.shared.ui.Transport; @Push(transport = Transport.LONG_POLLING) public class BasicPushLongPollingUI extends BasicPushUI { diff --git a/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/push/BasicPushWebsocketUI.java b/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/push/BasicPushWebsocketUI.java index d41c684c256..29bbcb468a2 100644 --- a/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/push/BasicPushWebsocketUI.java +++ b/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/push/BasicPushWebsocketUI.java @@ -3,7 +3,7 @@ import com.vaadin.ui.Push; import com.vaadin.flow.nodefeature.PushConfigurationMap; import com.vaadin.server.VaadinRequest; -import com.vaadin.shared.ui.ui.Transport; +import com.vaadin.shared.ui.Transport; @Push(transport = Transport.WEBSOCKET) public class BasicPushWebsocketUI extends BasicPushUI { diff --git a/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/push/BasicPushWebsocketXhrUI.java b/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/push/BasicPushWebsocketXhrUI.java index 78ea0a536f2..c6d449e5784 100644 --- a/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/push/BasicPushWebsocketXhrUI.java +++ b/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/push/BasicPushWebsocketXhrUI.java @@ -3,7 +3,7 @@ import com.vaadin.ui.Push; import com.vaadin.flow.nodefeature.PushConfigurationMap; import com.vaadin.server.VaadinRequest; -import com.vaadin.shared.ui.ui.Transport; +import com.vaadin.shared.ui.Transport; @Push(transport = Transport.WEBSOCKET_XHR) public class BasicPushWebsocketXhrUI extends BasicPushUI { From 88b2d7c07fad94fbf2164518f25bfe16ce705895 Mon Sep 17 00:00:00 2001 From: Giovanni Lovato Date: Wed, 18 Oct 2017 22:07:40 +0200 Subject: [PATCH 3/4] Move AttachEvent and DetachEvent to com.vaadin.ui.event (#2717) --- .../src/main/java/com/vaadin/flow/demo/views/DemoView.java | 2 +- .../com/vaadin/flow/tutorial/component/ComponentAttach.java | 4 ++-- flow-server/src/main/java/com/vaadin/ui/AngularTemplate.java | 2 +- flow-server/src/main/java/com/vaadin/ui/Component.java | 4 ++-- flow-server/src/main/java/com/vaadin/ui/ComponentUtil.java | 4 ++-- flow-server/src/main/java/com/vaadin/ui/UI.java | 4 ++-- .../java/com/vaadin/ui/common/AbstractAttachDetachEvent.java | 2 ++ .../src/main/java/com/vaadin/ui/common/AttachNotifier.java | 1 + .../src/main/java/com/vaadin/ui/common/DetachNotifier.java | 1 + .../java/com/vaadin/ui/{common => event}/AttachEvent.java | 3 ++- .../java/com/vaadin/ui/{common => event}/DetachEvent.java | 3 ++- flow-server/src/test/java/com/vaadin/ui/ComponentTest.java | 4 ++-- flow-server/src/test/java/com/vaadin/ui/CompositeTest.java | 4 ++-- flow-server/src/test/java/com/vaadin/ui/UITest.java | 4 ++-- .../src/main/java/com/vaadin/spring/scopes/VaadinUIScope.java | 2 +- .../main/java/com/vaadin/flow/uitest/ui/DependencyView.java | 2 +- .../main/java/com/vaadin/flow/uitest/ui/FragmentLinkView.java | 2 +- .../java/com/vaadin/flow/uitest/ui/FragmentLinkView2.java | 2 +- .../src/main/java/com/vaadin/flow/uitest/ui/InfoView.java | 2 +- .../com/vaadin/flow/uitest/ui/TimingInfoReportedView.java | 2 +- .../uitest/ui/dependencies/DependenciesLoadingBaseUI.java | 2 +- .../vaadin/flow/uitest/ui/frontend/FrontendProtocolView.java | 2 +- .../com/vaadin/flow/uitest/ui/push/ClientServerCounterUI.java | 2 +- .../flow/uitest/ui/template/PolymerModelPropertiesView.java | 2 +- .../flow/uitest/ui/template/imports/LazyWidgetView.java | 2 +- .../src/main/java/com/vaadin/flow/spring/ChildTemplate.java | 2 +- .../java/com/vaadin/flow/spring/RootNavigationTarget.java | 2 +- .../src/main/java/com/vaadin/flow/spring/UIScopeTarget.java | 2 +- 28 files changed, 38 insertions(+), 32 deletions(-) rename flow-server/src/main/java/com/vaadin/ui/{common => event}/AttachEvent.java (95%) rename flow-server/src/main/java/com/vaadin/ui/{common => event}/DetachEvent.java (92%) diff --git a/flow-components-parent/demo-flow-components/src/main/java/com/vaadin/flow/demo/views/DemoView.java b/flow-components-parent/demo-flow-components/src/main/java/com/vaadin/flow/demo/views/DemoView.java index fcfd5f43906..78086a5692a 100644 --- a/flow-components-parent/demo-flow-components/src/main/java/com/vaadin/flow/demo/views/DemoView.java +++ b/flow-components-parent/demo-flow-components/src/main/java/com/vaadin/flow/demo/views/DemoView.java @@ -26,9 +26,9 @@ import com.vaadin.ui.Component; import com.vaadin.ui.Tag; import com.vaadin.ui.UI; -import com.vaadin.ui.common.AttachEvent; import com.vaadin.ui.common.HasComponents; import com.vaadin.ui.common.StyleSheet; +import com.vaadin.ui.event.AttachEvent; import com.vaadin.ui.html.H3; /** diff --git a/flow-documentation/src/main/java/com/vaadin/flow/tutorial/component/ComponentAttach.java b/flow-documentation/src/main/java/com/vaadin/flow/tutorial/component/ComponentAttach.java index f3065c0616e..411c3a7c84b 100644 --- a/flow-documentation/src/main/java/com/vaadin/flow/tutorial/component/ComponentAttach.java +++ b/flow-documentation/src/main/java/com/vaadin/flow/tutorial/component/ComponentAttach.java @@ -4,10 +4,10 @@ import java.util.function.Consumer; import com.vaadin.flow.tutorial.annotations.CodeFor; -import com.vaadin.ui.common.AttachEvent; import com.vaadin.ui.Component; import com.vaadin.ui.Tag; -import com.vaadin.ui.common.DetachEvent; +import com.vaadin.ui.event.AttachEvent; +import com.vaadin.ui.event.DetachEvent; @CodeFor("creating-components/tutorial-component-with-dependencies.asciidoc") public class ComponentAttach { diff --git a/flow-server/src/main/java/com/vaadin/ui/AngularTemplate.java b/flow-server/src/main/java/com/vaadin/ui/AngularTemplate.java index 9d92fbe160a..a9d1261d813 100644 --- a/flow-server/src/main/java/com/vaadin/ui/AngularTemplate.java +++ b/flow-server/src/main/java/com/vaadin/ui/AngularTemplate.java @@ -32,6 +32,7 @@ import com.vaadin.flow.router.HasChildView; import com.vaadin.flow.router.RouterConfiguration; import com.vaadin.flow.router.View; +import com.vaadin.ui.event.AttachEvent; import com.vaadin.ui.polymertemplate.AbstractTemplate; import com.vaadin.flow.template.angular.RelativeFileResolver; import com.vaadin.flow.template.angular.TemplateNode; @@ -42,7 +43,6 @@ import com.vaadin.flow.template.angular.model.TemplateModelTypeParser; import com.vaadin.flow.template.angular.parser.TemplateParser; import com.vaadin.flow.template.angular.parser.TemplateResolver; -import com.vaadin.ui.common.AttachEvent; import com.vaadin.util.ReflectTools; /** diff --git a/flow-server/src/main/java/com/vaadin/ui/Component.java b/flow-server/src/main/java/com/vaadin/ui/Component.java index 75dcdb9947a..6625eeb00be 100644 --- a/flow-server/src/main/java/com/vaadin/ui/Component.java +++ b/flow-server/src/main/java/com/vaadin/ui/Component.java @@ -24,17 +24,17 @@ import com.vaadin.flow.dom.ElementUtil; import com.vaadin.flow.dom.ShadowRoot; import com.vaadin.shared.Registration; -import com.vaadin.ui.common.AttachEvent; import com.vaadin.ui.common.AttachNotifier; -import com.vaadin.ui.common.DetachEvent; import com.vaadin.ui.common.DetachNotifier; import com.vaadin.ui.common.HasElement; import com.vaadin.ui.common.PropertyDescriptor; import com.vaadin.ui.common.PropertyDescriptors; +import com.vaadin.ui.event.AttachEvent; import com.vaadin.ui.event.ComponentEvent; import com.vaadin.ui.event.ComponentEventBus; import com.vaadin.ui.event.ComponentEventListener; import com.vaadin.ui.event.ComponentEventNotifier; +import com.vaadin.ui.event.DetachEvent; import com.vaadin.util.AnnotationReader; /** diff --git a/flow-server/src/main/java/com/vaadin/ui/ComponentUtil.java b/flow-server/src/main/java/com/vaadin/ui/ComponentUtil.java index 7651f7913ff..ca2ddbe6ac7 100644 --- a/flow-server/src/main/java/com/vaadin/ui/ComponentUtil.java +++ b/flow-server/src/main/java/com/vaadin/ui/ComponentUtil.java @@ -27,12 +27,12 @@ import com.vaadin.ui.Component.MapToExistingElement; import com.vaadin.ui.ComponentMetaData.DependencyInfo; import com.vaadin.ui.ComponentMetaData.SynchronizedPropertyInfo; -import com.vaadin.ui.common.AttachEvent; -import com.vaadin.ui.common.DetachEvent; import com.vaadin.ui.common.HtmlImport; import com.vaadin.ui.common.JavaScript; import com.vaadin.ui.common.StyleSheet; import com.vaadin.ui.common.Uses; +import com.vaadin.ui.event.AttachEvent; +import com.vaadin.ui.event.DetachEvent; /** * Utility methods for {@link Component}. diff --git a/flow-server/src/main/java/com/vaadin/ui/UI.java b/flow-server/src/main/java/com/vaadin/ui/UI.java index 50286013be7..26260793692 100644 --- a/flow-server/src/main/java/com/vaadin/ui/UI.java +++ b/flow-server/src/main/java/com/vaadin/ui/UI.java @@ -46,9 +46,9 @@ import com.vaadin.server.VaadinSession; import com.vaadin.server.communication.PushConnection; import com.vaadin.shared.ApplicationConstants; -import com.vaadin.ui.common.AttachEvent; -import com.vaadin.ui.common.DetachEvent; import com.vaadin.ui.common.HasComponents; +import com.vaadin.ui.event.AttachEvent; +import com.vaadin.ui.event.DetachEvent; import com.vaadin.util.CurrentInstance; /** diff --git a/flow-server/src/main/java/com/vaadin/ui/common/AbstractAttachDetachEvent.java b/flow-server/src/main/java/com/vaadin/ui/common/AbstractAttachDetachEvent.java index 2c0e5a1f22c..a2c563ca844 100644 --- a/flow-server/src/main/java/com/vaadin/ui/common/AbstractAttachDetachEvent.java +++ b/flow-server/src/main/java/com/vaadin/ui/common/AbstractAttachDetachEvent.java @@ -18,7 +18,9 @@ import com.vaadin.server.VaadinSession; import com.vaadin.ui.Component; import com.vaadin.ui.UI; +import com.vaadin.ui.event.AttachEvent; import com.vaadin.ui.event.ComponentEvent; +import com.vaadin.ui.event.DetachEvent; /** * Internal helper for {@link AttachEvent} and {@link DetachEvent}. diff --git a/flow-server/src/main/java/com/vaadin/ui/common/AttachNotifier.java b/flow-server/src/main/java/com/vaadin/ui/common/AttachNotifier.java index eba8bfc8997..02c5639c566 100644 --- a/flow-server/src/main/java/com/vaadin/ui/common/AttachNotifier.java +++ b/flow-server/src/main/java/com/vaadin/ui/common/AttachNotifier.java @@ -15,6 +15,7 @@ */ package com.vaadin.ui.common; +import com.vaadin.ui.event.AttachEvent; import com.vaadin.ui.event.ComponentEventListener; import com.vaadin.shared.Registration; import com.vaadin.ui.event.ComponentEventNotifier; diff --git a/flow-server/src/main/java/com/vaadin/ui/common/DetachNotifier.java b/flow-server/src/main/java/com/vaadin/ui/common/DetachNotifier.java index 1de029d8d40..67b8f54b093 100644 --- a/flow-server/src/main/java/com/vaadin/ui/common/DetachNotifier.java +++ b/flow-server/src/main/java/com/vaadin/ui/common/DetachNotifier.java @@ -18,6 +18,7 @@ import com.vaadin.ui.event.ComponentEventListener; import com.vaadin.shared.Registration; import com.vaadin.ui.event.ComponentEventNotifier; +import com.vaadin.ui.event.DetachEvent; /** * Mixin interface for components that support adding detach listeners. diff --git a/flow-server/src/main/java/com/vaadin/ui/common/AttachEvent.java b/flow-server/src/main/java/com/vaadin/ui/event/AttachEvent.java similarity index 95% rename from flow-server/src/main/java/com/vaadin/ui/common/AttachEvent.java rename to flow-server/src/main/java/com/vaadin/ui/event/AttachEvent.java index aecaa22ef83..659e45d359e 100644 --- a/flow-server/src/main/java/com/vaadin/ui/common/AttachEvent.java +++ b/flow-server/src/main/java/com/vaadin/ui/event/AttachEvent.java @@ -13,9 +13,10 @@ * License for the specific language governing permissions and limitations under * the License. */ -package com.vaadin.ui.common; +package com.vaadin.ui.event; import com.vaadin.ui.Component; +import com.vaadin.ui.common.AbstractAttachDetachEvent; /** * Event fired after a {@link Component} is attached to the UI. diff --git a/flow-server/src/main/java/com/vaadin/ui/common/DetachEvent.java b/flow-server/src/main/java/com/vaadin/ui/event/DetachEvent.java similarity index 92% rename from flow-server/src/main/java/com/vaadin/ui/common/DetachEvent.java rename to flow-server/src/main/java/com/vaadin/ui/event/DetachEvent.java index c6b83bf6bba..b955e97b3b6 100644 --- a/flow-server/src/main/java/com/vaadin/ui/common/DetachEvent.java +++ b/flow-server/src/main/java/com/vaadin/ui/event/DetachEvent.java @@ -13,9 +13,10 @@ * License for the specific language governing permissions and limitations under * the License. */ -package com.vaadin.ui.common; +package com.vaadin.ui.event; import com.vaadin.ui.Component; +import com.vaadin.ui.common.AbstractAttachDetachEvent; /** * Event fired before a {@link Component} is detached from the UI. diff --git a/flow-server/src/test/java/com/vaadin/ui/ComponentTest.java b/flow-server/src/test/java/com/vaadin/ui/ComponentTest.java index 3c0ad681e78..5e6d43a5ac1 100644 --- a/flow-server/src/test/java/com/vaadin/ui/ComponentTest.java +++ b/flow-server/src/test/java/com/vaadin/ui/ComponentTest.java @@ -44,16 +44,16 @@ import com.vaadin.shared.Registration; import com.vaadin.shared.ui.Dependency; import com.vaadin.tests.util.TestUtil; -import com.vaadin.ui.common.AttachEvent; import com.vaadin.ui.common.DependencyList; -import com.vaadin.ui.common.DetachEvent; import com.vaadin.ui.common.HtmlImport; import com.vaadin.ui.common.JavaScript; import com.vaadin.ui.common.StyleSheet; import com.vaadin.ui.common.Uses; +import com.vaadin.ui.event.AttachEvent; import com.vaadin.ui.event.ComponentEvent; import com.vaadin.ui.event.ComponentEventBus; import com.vaadin.ui.event.ComponentEventListener; +import com.vaadin.ui.event.DetachEvent; import com.vaadin.ui.event.Synchronize; public class ComponentTest { diff --git a/flow-server/src/test/java/com/vaadin/ui/CompositeTest.java b/flow-server/src/test/java/com/vaadin/ui/CompositeTest.java index 72f340a56ae..2d7e6875f02 100644 --- a/flow-server/src/test/java/com/vaadin/ui/CompositeTest.java +++ b/flow-server/src/test/java/com/vaadin/ui/CompositeTest.java @@ -22,9 +22,9 @@ import com.vaadin.ui.ComponentTest.TestComponent; import com.vaadin.ui.ComponentTest.TracksAttachDetach; import com.vaadin.ui.CompositeNestedTest.TestLayout; -import com.vaadin.ui.common.AttachEvent; -import com.vaadin.ui.common.DetachEvent; +import com.vaadin.ui.event.AttachEvent; import com.vaadin.ui.event.ComponentEventListener; +import com.vaadin.ui.event.DetachEvent; import com.vaadin.ui.polymertemplate.PolymerTemplate; public class CompositeTest { diff --git a/flow-server/src/test/java/com/vaadin/ui/UITest.java b/flow-server/src/test/java/com/vaadin/ui/UITest.java index 1982296d515..2f9751d78ad 100644 --- a/flow-server/src/test/java/com/vaadin/ui/UITest.java +++ b/flow-server/src/test/java/com/vaadin/ui/UITest.java @@ -31,8 +31,8 @@ import com.vaadin.server.VaadinService; import com.vaadin.server.VaadinServlet; import com.vaadin.ui.History.HistoryStateChangeEvent; -import com.vaadin.ui.common.AttachEvent; -import com.vaadin.ui.common.DetachEvent; +import com.vaadin.ui.event.AttachEvent; +import com.vaadin.ui.event.DetachEvent; import com.vaadin.util.CurrentInstance; public class UITest { diff --git a/flow-spring-addon/src/main/java/com/vaadin/spring/scopes/VaadinUIScope.java b/flow-spring-addon/src/main/java/com/vaadin/spring/scopes/VaadinUIScope.java index 5de6f6fe559..e94a6ee588f 100644 --- a/flow-spring-addon/src/main/java/com/vaadin/spring/scopes/VaadinUIScope.java +++ b/flow-spring-addon/src/main/java/com/vaadin/spring/scopes/VaadinUIScope.java @@ -25,8 +25,8 @@ import com.vaadin.shared.Registration; import com.vaadin.spring.SpringVaadinSession; import com.vaadin.ui.UI; -import com.vaadin.ui.common.DetachEvent; import com.vaadin.ui.event.ComponentEventListener; +import com.vaadin.ui.event.DetachEvent; /** * Implementation of Spring's diff --git a/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/DependencyView.java b/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/DependencyView.java index 6869157d112..2424dcc8f7d 100644 --- a/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/DependencyView.java +++ b/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/DependencyView.java @@ -27,9 +27,9 @@ import com.vaadin.ui.Tag; import com.vaadin.ui.Text; import com.vaadin.ui.UI; -import com.vaadin.ui.common.AttachEvent; import com.vaadin.ui.common.HasText; import com.vaadin.ui.common.HtmlImport; +import com.vaadin.ui.event.AttachEvent; import com.vaadin.ui.html.Div; import com.vaadin.ui.html.Hr; import com.vaadin.ui.html.NativeButton; diff --git a/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/FragmentLinkView.java b/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/FragmentLinkView.java index c8f71d14283..8d8b7f4c544 100644 --- a/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/FragmentLinkView.java +++ b/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/FragmentLinkView.java @@ -2,8 +2,8 @@ import com.vaadin.flow.dom.Element; import com.vaadin.flow.dom.ElementFactory; -import com.vaadin.ui.common.AttachEvent; import com.vaadin.ui.History.HistoryStateChangeHandler; +import com.vaadin.ui.event.AttachEvent; import com.vaadin.ui.Page; public class FragmentLinkView extends AbstractDivView { diff --git a/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/FragmentLinkView2.java b/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/FragmentLinkView2.java index 898f3eabde3..7bd421f3822 100644 --- a/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/FragmentLinkView2.java +++ b/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/FragmentLinkView2.java @@ -1,7 +1,7 @@ package com.vaadin.flow.uitest.ui; import com.vaadin.flow.dom.Element; -import com.vaadin.ui.common.AttachEvent; +import com.vaadin.ui.event.AttachEvent; public class FragmentLinkView2 extends FragmentLinkView { diff --git a/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/InfoView.java b/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/InfoView.java index f283b4aa544..dde2d2e9a07 100644 --- a/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/InfoView.java +++ b/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/InfoView.java @@ -26,9 +26,9 @@ import com.vaadin.function.DeploymentConfiguration; import com.vaadin.server.VaadinSession; import com.vaadin.server.WebBrowser; -import com.vaadin.ui.common.AttachEvent; import com.vaadin.ui.Html; import com.vaadin.ui.UI; +import com.vaadin.ui.event.AttachEvent; public class InfoView extends Div implements View { diff --git a/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/TimingInfoReportedView.java b/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/TimingInfoReportedView.java index af71d90032b..4b84fc3ce14 100644 --- a/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/TimingInfoReportedView.java +++ b/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/TimingInfoReportedView.java @@ -16,9 +16,9 @@ package com.vaadin.flow.uitest.ui; import com.vaadin.ui.html.NativeButton; +import com.vaadin.ui.event.AttachEvent; import com.vaadin.ui.html.Div; import com.vaadin.flow.router.View; -import com.vaadin.ui.common.AttachEvent; /** * @author Vaadin Ltd diff --git a/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/dependencies/DependenciesLoadingBaseUI.java b/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/dependencies/DependenciesLoadingBaseUI.java index 6ddda74413c..ae5fcd17b57 100644 --- a/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/dependencies/DependenciesLoadingBaseUI.java +++ b/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/dependencies/DependenciesLoadingBaseUI.java @@ -2,8 +2,8 @@ import com.vaadin.ui.html.Div; import com.vaadin.server.VaadinRequest; -import com.vaadin.ui.common.AttachEvent; import com.vaadin.ui.UI; +import com.vaadin.ui.event.AttachEvent; /** * This class provides test base for IT test that check dependencies being diff --git a/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/frontend/FrontendProtocolView.java b/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/frontend/FrontendProtocolView.java index f2aa90a59c7..0c5061e0ef5 100644 --- a/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/frontend/FrontendProtocolView.java +++ b/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/frontend/FrontendProtocolView.java @@ -16,10 +16,10 @@ package com.vaadin.flow.uitest.ui.frontend; import com.vaadin.flow.router.View; -import com.vaadin.ui.common.AttachEvent; import com.vaadin.ui.Component; import com.vaadin.ui.Tag; import com.vaadin.ui.common.HasComponents; +import com.vaadin.ui.event.AttachEvent; /** * Wrapper view for the {@link FrontendProtocolTemplate} component. This class diff --git a/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/push/ClientServerCounterUI.java b/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/push/ClientServerCounterUI.java index 44c3424fa57..7bfc0916a10 100644 --- a/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/push/ClientServerCounterUI.java +++ b/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/push/ClientServerCounterUI.java @@ -7,8 +7,8 @@ import com.vaadin.flow.dom.ElementFactory; import com.vaadin.ui.html.NativeButton; import com.vaadin.server.VaadinRequest; -import com.vaadin.ui.common.DetachEvent; import com.vaadin.ui.UI; +import com.vaadin.ui.event.DetachEvent; public class ClientServerCounterUI extends UI { diff --git a/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/template/PolymerModelPropertiesView.java b/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/template/PolymerModelPropertiesView.java index 52621e21373..ede7beaebe0 100644 --- a/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/template/PolymerModelPropertiesView.java +++ b/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/template/PolymerModelPropertiesView.java @@ -17,8 +17,8 @@ import com.vaadin.flow.router.View; import com.vaadin.ui.Tag; -import com.vaadin.ui.common.AttachEvent; import com.vaadin.ui.common.HtmlImport; +import com.vaadin.ui.event.AttachEvent; import com.vaadin.ui.event.ComponentEvent; import com.vaadin.ui.event.DomEvent; import com.vaadin.ui.html.Div; diff --git a/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/template/imports/LazyWidgetView.java b/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/template/imports/LazyWidgetView.java index 5357f0644e1..aac58723613 100644 --- a/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/template/imports/LazyWidgetView.java +++ b/flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/template/imports/LazyWidgetView.java @@ -19,9 +19,9 @@ import com.vaadin.flow.router.View; import com.vaadin.shared.ui.LoadMode; import com.vaadin.ui.Tag; -import com.vaadin.ui.common.AttachEvent; import com.vaadin.ui.common.ClientDelegate; import com.vaadin.ui.common.HtmlImport; +import com.vaadin.ui.event.AttachEvent; import com.vaadin.ui.polymertemplate.PolymerTemplate; @Tag("x-lazy-widget") diff --git a/flow-tests/test-spring-common/src/main/java/com/vaadin/flow/spring/ChildTemplate.java b/flow-tests/test-spring-common/src/main/java/com/vaadin/flow/spring/ChildTemplate.java index f5d90f6ae03..7f3dbb9c731 100644 --- a/flow-tests/test-spring-common/src/main/java/com/vaadin/flow/spring/ChildTemplate.java +++ b/flow-tests/test-spring-common/src/main/java/com/vaadin/flow/spring/ChildTemplate.java @@ -21,8 +21,8 @@ import com.vaadin.flow.model.TemplateModel; import com.vaadin.spring.annotation.VaadinSessionScope; import com.vaadin.ui.Tag; -import com.vaadin.ui.common.AttachEvent; import com.vaadin.ui.common.HtmlImport; +import com.vaadin.ui.event.AttachEvent; import com.vaadin.ui.polymertemplate.PolymerTemplate; @Tag("child-template") diff --git a/flow-tests/test-spring-common/src/main/java/com/vaadin/flow/spring/RootNavigationTarget.java b/flow-tests/test-spring-common/src/main/java/com/vaadin/flow/spring/RootNavigationTarget.java index 3370870554c..0e45fbaa6cc 100644 --- a/flow-tests/test-spring-common/src/main/java/com/vaadin/flow/spring/RootNavigationTarget.java +++ b/flow-tests/test-spring-common/src/main/java/com/vaadin/flow/spring/RootNavigationTarget.java @@ -18,7 +18,7 @@ import org.springframework.beans.factory.annotation.Autowired; import com.vaadin.router.Route; -import com.vaadin.ui.common.AttachEvent; +import com.vaadin.ui.event.AttachEvent; import com.vaadin.ui.html.Div; import com.vaadin.ui.html.Label; diff --git a/flow-tests/test-spring-common/src/main/java/com/vaadin/flow/spring/UIScopeTarget.java b/flow-tests/test-spring-common/src/main/java/com/vaadin/flow/spring/UIScopeTarget.java index 39a14768474..55e3424c79c 100644 --- a/flow-tests/test-spring-common/src/main/java/com/vaadin/flow/spring/UIScopeTarget.java +++ b/flow-tests/test-spring-common/src/main/java/com/vaadin/flow/spring/UIScopeTarget.java @@ -21,7 +21,7 @@ import org.springframework.stereotype.Component; import com.vaadin.router.Route; -import com.vaadin.ui.common.AttachEvent; +import com.vaadin.ui.event.AttachEvent; import com.vaadin.ui.html.Div; import com.vaadin.ui.html.Label; From 3355be8b043951c91e3c70fc2ed60d87698d36ae Mon Sep 17 00:00:00 2001 From: Kirill Bulatov Date: Thu, 19 Oct 2017 01:35:40 +0300 Subject: [PATCH 4/4] Update documentation. --- .../tutorial-flow-components-setup.asciidoc | 135 ++++++++++++++---- .../java/com/vaadin/server/Constants.java | 2 +- 2 files changed, 111 insertions(+), 26 deletions(-) diff --git a/flow-documentation/flow-components/tutorial-flow-components-setup.asciidoc b/flow-documentation/flow-components/tutorial-flow-components-setup.asciidoc index 3122d8b5652..7de316618a7 100644 --- a/flow-documentation/flow-components/tutorial-flow-components-setup.asciidoc +++ b/flow-documentation/flow-components/tutorial-flow-components-setup.asciidoc @@ -7,40 +7,116 @@ layout: page = Setup your project to use Flow components Flow provides some pre-built server-side components for Vaadin webcomponents, -such as `VaadinButton`, `VaadinTextField` and so on. Those components are part of +such as `Button`, `TextField` and so on. Those components are part of the `flow-components` package, that can be added as an optional dependency to any Flow project. -== Maven configuration += Overview + +`flow-components` package consists of two main sections: + +* java api classes (`Button`, `TextField`, etc) +* web components' files (html, js, css etc) + +All sections are used by `flow` to display the components in web pages correctly. +By default, both sections are provided in the same jar. + +Web components' files are provided as https://github.com/webjars/webjars/[webjars] – +jar files that contain webcomponents' files, +heavily influenced by current Polymer package manager: https://bower.io/[bower] +(not developed or maintained by Vaadin) + +Webjars are designed to replace `bower` usage by using `Maven` for the same purposes. + +`Flow` is able to resolve requests into webjars' contents (if intended by request), +imitating the regular web component's files. + +Although currently enabled by default, webjars do not restrict users from using external +web components' files: + +* webjar resolving can be turned off +* if no suitable webjar is found, request resolving falls back to configured +external web components' locations [NOTE] -Before you configure your project to use Flow components, make sure it is -properly configured to run with Polymer webcomponents. Please refer to -<<../web-components/tutorial-webcomponent-basic#,Basic Integration of a Polymer Web Component>> -for more information. +Due to current webjar https://github.com/webjars/webjars/issues[limitations], +extra maven configuration (extra repository + bom file declaration) is required. -The first step is to add the `flow-components` package to your project +== Maven configuration + +The first step is to add the `bom` and `flow-components` package to your project dependencies. This package is released alongside Flow and shares the same -version number. When using Maven you can add it to your `pom.xml` as this: +version number. When using Maven you can add it into your `pom.xml` as this: [source,xml] ---- - - com.vaadin - flow-components - ${flow.version} - + + + + webjars + https://dl.bintray.com/webjars/maven + + + + + + + + com.vaadin + vaadin-webjars-bom + pom + import + ${project.version} + + + + + + + + + + com.vaadin + flow-components + ${flow.version} + + + + ---- -[TIP] -To enable compilation to ES5 (for browsers that lack of ES6 support, such as - IE11), you need extra configuration, which is described at - <<../web-components/tutorial-webcomponents-es5#,Serving ES5 Web Components to older browsers with Polymer 2>> +== Runtime configuration + +Extra parameters can be specified to configure `flow`: + +* disable.webjars - if set to `true`, webjars would be ignored during request resolving, +allows `flow` to use external source of web components' files. +[NOTE] +Webjars are enabled for development mode and disabled for production mode by default, +unless explicitly overridden by parameter specified. +In future, webjars should be expected to be enabled always. + +Next group of parameters are paths to external web component's locations in development and production modes. + +Development mode: + +* frontend.url.dev (default value is context://frontend) – a location `flow` searches web components' files in development mode. +Supports changes reload on a working application and should be set as a directory, containing `bower.json` file. +By default, `flow` looks for files in `frontend` directory, +located in https://docs.jboss.org/jbossas/guides/webguide/r2/en/html/ch06.html[context root] of the application + +Production mode: + +* frontend.url.es5 (default value is context://frontend-es5) - a location `flow` searches web components' files in production mode +when the request is coming from older browsers, not supporting http://es6-features.org/[es6], default web components' development language version. +* frontend.url.es6 (default value is context://frontend-es6) - a location `flow` searches web components' files in production mode for requests from modern browsers == bower.json configuration -In your `bower.json` file, which is located at `${frontend.working.directory}` -(see <<../web-components/tutorial-webcomponent-basic#,Basic Integration of a Polymer Web Component>> for details), you +Currently `bower.json` is needed for production mode and in cases wne you'd like to be able +to manipulate web component's files before adding them to the application (transpile, minify, check, bundle etc) + +In your `bower.json` file, which is located at `${frontend.working.directory}`, you need to add the webcomponent dependencies to each desired webcomponent. Here is an example that adds all supported elements: @@ -49,12 +125,12 @@ an example that adds all supported elements: { // [...] other properties "dependencies": { - "polymer": "~2.0.2", - "vaadin-text-field": "~1.1.0-alpha2", - "vaadin-button": "~1.0.0", - "vaadin-checkbox": "~1.0.0-alpha1", - "vaadin-combo-box": "~2.0.0", - "vaadin-form-layout": "~1.0.0" + "polymer": "2.0.2", + "vaadin-text-field": "1.1.0-alpha2", + "vaadin-button": "1.0.0", + "vaadin-checkbox": "1.0.0-alpha1", + "vaadin-combo-box": "2.0.0", + "vaadin-form-layout": "1.0.0" } } ---- @@ -66,6 +142,15 @@ You only need to add the webcomponents you are going to use in your project. There's no harm to add webcomponents that you are not going to use at the server-side, except that the final `war` size will be larger for no reason. +[TIP] +To enable compilation to ES5 (for browsers that lack of ES6 support, such as + IE11), you need extra configuration, which is described at + <<../web-components/tutorial-webcomponents-es5#,Serving ES5 Web Components to older browsers with Polymer 2>> + +[NOTE] +How to integrate java and web components' files is explained in +<<../web-components/tutorial-webcomponent-basic#,Basic Integration of a Polymer Web Component>>. + == Demo and code samples The Flow components demo at http://flow.app.fi contains examples of diff --git a/flow-server/src/main/java/com/vaadin/server/Constants.java b/flow-server/src/main/java/com/vaadin/server/Constants.java index d3d51c4a52f..ac1f9e6daf6 100644 --- a/flow-server/src/main/java/com/vaadin/server/Constants.java +++ b/flow-server/src/main/java/com/vaadin/server/Constants.java @@ -92,7 +92,7 @@ public final class Constants implements Serializable { * Configuration name for the parameter that determines if Flow should use * webJars or not. */ - public static final String DISABLE_WEBJARS = "disable.webjar"; + public static final String DISABLE_WEBJARS = "disable.webjars"; private Constants() { // prevent instantiation constants class only