-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use serverInitiatedProgress instead of custom notifications #34
Comments
This is already done, just haven't pushed yet. |
I would like to reopen this issue (but I can't due to GitHub permissions). I tested the 9.0.0 alpha and it seams that the specification for serverInitiatedProgress is not met. I think currently the server is implementing clientInitiatedProgress insted. But in this case the progress should be initiated by LTEX-LS. The specification requires the server to
Additionaly,
|
The server didn't use client-initiated progress as the tokens used by the server notifications are not introduced by the client before the server notifications. Just the |
Does work now with the LSP client for Sublime Text too. |
Fix released in 9.0.0. |
Is your feature request related to a problem? Please describe.
ltex-ls is using custom notifications for progress reporting.
Describe the solution you'd like
Replace it with the standard server initiated progress scheme of the LSP specification.
See microsoft/pyright#1268 for a analog discussion
ltex/progress
, with progress 0.0 -->window/workDoneProgress/create
+$/progress
with kind beginltex/progress
, with progress 1.0 -->$/progress with kind end
Additional context
Simplifies integration with non vscode-ltex clients.
The text was updated successfully, but these errors were encountered: