Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for False Friends #11

Closed
cattaneod opened this issue Oct 2, 2019 · 2 comments
Closed

Add Support for False Friends #11

cattaneod opened this issue Oct 2, 2019 · 2 comments
Assignees
Labels
1-feature-request ✨ Issue type: Request for a desirable, nice-to-have feature 3-fixed Issue resolution: Issue has been fixed on the develop branch

Comments

@cattaneod
Copy link

First, thank you very much for your work!

Would it be possible to add support for false friends, after setting the mother tongue?

@cattaneod cattaneod added the 1-feature-request ✨ Issue type: Request for a desirable, nice-to-have feature label Oct 2, 2019
@valentjn
Copy link
Owner

valentjn commented Oct 2, 2019

@catta202000 Thank you! And thanks for your suggestion. I didn't know about the false friends feature of LanguageTool.

LTEX 4.7.1 supports this with the new ltex.additionalRules.motherTongue setting. If you supply it without specifying a language model (n-gram data via ltex.additionalRules.languageModel), then a workaround uses the old false friend detection from LanguageTool's false-friends.xml.

For example, when checking English with German mother tongue, the wrong My handy is broken. (handy is a German pseudo-anglicism for mobile phone) will be warned about with and without a language model, but the correct This will come in handy. will be erroneously warned about only without a language model.

@valentjn valentjn closed this as completed Oct 2, 2019
@valentjn valentjn added the 3-fixed Issue resolution: Issue has been fixed on the develop branch label Oct 2, 2019
@valentjn valentjn self-assigned this Oct 2, 2019
@cattaneod
Copy link
Author

That was super fast!
Thank you so much for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-feature-request ✨ Issue type: Request for a desirable, nice-to-have feature 3-fixed Issue resolution: Issue has been fixed on the develop branch
Projects
None yet
Development

No branches or pull requests

2 participants