Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for external LanguageTool servers #36

Closed
valentjn opened this issue May 1, 2020 · 9 comments
Closed

Add support for external LanguageTool servers #36

valentjn opened this issue May 1, 2020 · 9 comments
Assignees
Labels
1-feature-request ✨ Issue type: Request for a desirable, nice-to-have feature 3-fixed Issue resolution: Issue has been fixed on the develop branch
Milestone

Comments

@valentjn
Copy link
Owner

valentjn commented May 1, 2020

Is your feature request related to a problem? Please describe.
More advanced users might want to have their own instances of LanguageTool running on their local machines. For instance, in #34, there was a bug in LT that has been fixed in the development snapshot. Impatient users could run the LT server from the development snapshot for the fix, rather than having to wait for the next LT and LTEX release.

Describe the solution you'd like
Instead of using the built-in version of LT, connect to an LT server on localhost or wherever.

Describe alternatives you've considered
None.

Additional context
None.

@valentjn valentjn added the 1-feature-request ✨ Issue type: Request for a desirable, nice-to-have feature label May 1, 2020
@Zplusless
Copy link

start LT if it not running will be a good feature. Like Texstudio

@valentjn valentjn self-assigned this May 3, 2020
@valentjn
Copy link
Owner Author

valentjn commented May 3, 2020

@Zplusless The newly implemented solution relies on the user starting the server, as mostly experts will use the server feature anyway. TeXstudio is a different story as it's written in C++ and thus needs to use LT as a server, in contrast to LTEX's Java core which can directly interact with LT.

@valentjn valentjn added the 3-fixed Issue resolution: Issue has been fixed on the develop branch label May 3, 2020
@valentjn
Copy link
Owner Author

valentjn commented May 6, 2020

Fix released in 4.9.2.

@valentjn
Copy link
Owner Author

valentjn commented May 7, 2020

Reopening as the implementation depended on Java 11, which broke LTEX for some users (see #38). It's possible to implement this using a dependency, so this feature does not really on Java 11. Reverted this for now in 4.9.3.

@valentjn valentjn reopened this May 7, 2020
@valentjn valentjn removed the 3-fixed Issue resolution: Issue has been fixed on the develop branch label May 7, 2020
@ghost
Copy link

ghost commented May 20, 2020

I'm currently running a server locally with docker for LanguageTools extension to not rely on external service. I'd like to not run the service multiple times 😄

@valentjn valentjn added this to the 5.0.0 milestone May 20, 2020
@valentjn
Copy link
Owner Author

I have reimplemented this using Java 8. Still needs to be tested though. It should make it to the 5.0 release.

@valentjn
Copy link
Owner Author

The new implementation is now in master and can be tested via 5.0.0-beta.1. Seems to work for me. Unit tests still need to be implemented.

@valentjn valentjn added the 3-fixed Issue resolution: Issue has been fixed on the develop branch label May 24, 2020
@ghost
Copy link

ghost commented May 25, 2020

I will try it. Thanks.

For information, here how I run a local LanguageTool server

docker run --rm -p 9090:8010 --name languageTools erikvl87/languagetool

Server address is http://127.0.0.1:9090

@valentjn
Copy link
Owner Author

valentjn commented Jun 1, 2020

Fix released in 5.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-feature-request ✨ Issue type: Request for a desirable, nice-to-have feature 3-fixed Issue resolution: Issue has been fixed on the develop branch
Projects
None yet
Development

No branches or pull requests

2 participants