Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load languages on demand instead of having language extensions #6

Closed
valentjn opened this issue Sep 7, 2019 · 5 comments
Closed

Load languages on demand instead of having language extensions #6

valentjn opened this issue Sep 7, 2019 · 5 comments
Assignees
@valentjn
Labels
1-feature-request ✨ Issue type: Request for a desirable, nice-to-have feature 3-fixed Issue resolution: Issue has been fixed on the develop branch
Milestone
5.0.0

Comments

@valentjn
Copy link
Owner

valentjn commented Sep 7, 2019

All these language extensions pollute the Marketplace and are pretty confusing. It would be nice to have a prompt after installing LTEX allowing to download languages. We would still have to provide *.vsix files for offline installation.
@valentjn valentjn added the 1-feature-request ✨ Issue type: Request for a desirable, nice-to-have feature label Sep 7, 2019
@valentjn valentjn mentioned this issue Sep 13, 2019
Closed
@hirschsn
Copy link

You would also have to include some kind of update mechanism, wouldn't you?

@valentjn
Copy link
Owner Author

valentjn commented Sep 19, 2019 •
edited
Loading

@hirschsn I guess this could be handled by updates of the main extension (e.g., download the latest version of the language extension that has smaller or equal version number compared to the version of the main extension). Besides, the language extensions only really have to be updated if LT is updated. We'd have to make sure that the LT versions of main extension and language extension match.

BTW, I got the idea from here: https://github.com/microsoft/vscode-cpptools/tree/master/Extension#offline-installation

@valentjn valentjn self-assigned this May 14, 2020
@valentjn
Copy link
Owner Author

So the current status here is that I'm working on downloading all dependencies on-demand from within LTEX: language server, LanguageTool with all its languages, even Java if needed/desired (see #5). The initial version will only have the option to download all languages at once, not individually, since implementing that would require quite a bit of effort. However, as the main point of this issue was removing the need for the language extensions, this would solve this issue for me.

@valentjn valentjn added this to the 5.0.0 milestone May 20, 2020
@valentjn
Copy link
Owner Author

The code for downloading ltex-ls on-demand is now in master. As mentioned above, this is a feasible fix from my POV.

@valentjn valentjn added the 3-fixed Issue resolution: Issue has been fixed on the develop branch label May 24, 2020
@valentjn
Copy link
Owner Author

valentjn commented Jun 1, 2020

Fix released in 5.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentjn valentjn

Labels
1-feature-request ✨ Issue type: Request for a desirable, nice-to-have feature 3-fixed Issue resolution: Issue has been fixed on the develop branch
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
2 participants
@hirschsn @valentjn