Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Freezes for german since v6.0.0 #68

Closed
ahippler opened this issue Jul 2, 2020 · 5 comments
Closed

Freezes for german since v6.0.0 #68

ahippler opened this issue Jul 2, 2020 · 5 comments
Assignees
@valentjn
Labels
1-bug 🐛 Issue type: Bug report (something isn't working as expected) 2-confirmed Issue status: Confirmed, reproducible bug in LTeX 2-upstream Issue status: Bug is caused by some dependency, might have to wait before continuing 3-fixed Issue resolution: Issue has been fixed on the develop branch
Milestone
6.0.1

Comments

@ahippler
Copy link

ahippler commented Jul 2, 2020 •
edited
Loading

Describe the bug
Freezes after a couple of sentences with language "de-DE" since the update to v6.0.0.
Opening lager (more the 20 lines) files shows no errors (but there are some).
Restarting the language server does not solve the problem.

Steps to reproduce

  • language "de-DE"
  • write text or open lager files
  • ltex stops working

Sample document

Working:

Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Aenean commodo ligula
eget dolor. Aenean massa. Cum sociis natoque penatibus et magnis dis parturient
montes, nascetur ridiculus mus. Donec quam felis, ultricies nec, pellentesque
eu, pretium quis, sem. Nulla consequat massa quis enim. Donec pede justo,
fringilla vel, aliquet nec, vulputate eget, arcu. In enim justo, rhoncus ut,
imperdiet a, venenatis vitae, justo.

Stopps working:

Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Aenean commodo ligula
eget dolor. Aenean massa. Cum sociis natoque penatibus et magnis dis parturient
montes, nascetur ridiculus mus. Donec quam felis, ultricies nec, pellentesque
eu, pretium quis, sem. Nulla consequat massa quis enim. Donec pede justo,
fringilla vel, aliquet nec, vulputate eget, arcu. In enim justo, rhoncus ut,
imperdiet a, venenatis vitae, justo. Nullam

LTeX configuration

  "ltex.language": "de-DE",

"LTeX Language Server" log file

[Info  - 3:35:37 PM] Starte ltex-ls ...
Juli 02, 2020 3:35:40 PM org.bsplines.ltexls.LtexLanguageServer initialize
INFORMATION: Setting locale to de
Juli 02, 2020 3:35:46 PM org.bsplines.ltexls.DocumentChecker checkAnnotatedTextFragment
INFORMATION: Checking the following text in language de-DE via LanguageTool: "..."... (truncated to 100 characters)
Juli 02, 2020 3:35:49 PM org.bsplines.ltexls.DocumentChecker checkAnnotatedTextFragment
INFORMATION: Obtained 11 rule matches
Juli 02, 2020 3:36:04 PM org.eclipse.lsp4j.jsonrpc.RemoteEndpoint handleCancellation
WARNUNG: Unmatched cancel notification for request id 2

"LTeX Language Client" log file
shows no difference between 5.0.2 and 6.0.0

Version information
List here the version information of the relevant software.

  • Operating system: macOS 10.15.5
  • VS Code: 1.46.1
  • vscode-ltex: 6.0.0
  • Java: openjdk version "14.0.1" 2020-04-14

Additional context/information
Using diffrent java version does not help.
Changing the language to english and killing the java process solves the problem.
As a workaround i downgraded to vscode-ltex 5.0.2 which is working fine with the same documents.
@ahippler ahippler added 1-bug 🐛 Issue type: Bug report (something isn't working as expected) 2-unconfirmed Issue status: Bug that needs to be reproduced (all new bugs have this label) labels Jul 2, 2020
@valentjn
Copy link
Owner

valentjn commented Jul 2, 2020 via email

@ahippler
Copy link
Author

ahippler commented Jul 2, 2020 •
edited
Loading

Maybe it stops working when it detects too many errors? It looks like the number of errors makes the difference not the length of the text.

@valentjn valentjn added 2-confirmed Issue status: Confirmed, reproducible bug in LTeX and removed 2-unconfirmed Issue status: Bug that needs to be reproduced (all new bugs have this label) labels Jul 2, 2020
@valentjn
Copy link
Owner

valentjn commented Jul 2, 2020

I think this is caused by languagetool-org/languagetool#3181. LanguageTool 5.0 writes random stuff to stdout and that messes up the LSP communication, resulting in a deadlock.

@valentjn valentjn added the 2-upstream Issue status: Bug is caused by some dependency, might have to wait before continuing label Jul 2, 2020
@valentjn valentjn added the 3-fixed Issue resolution: Issue has been fixed on the develop branch label Jul 2, 2020
@valentjn valentjn self-assigned this Jul 2, 2020
@valentjn valentjn added this to the 6.0.1 milestone Jul 2, 2020
@valentjn
Copy link
Owner

valentjn commented Jul 2, 2020

Implemented a workaround in 6.0.1. Thanks for the report.

@ahippler
Copy link
Author

ahippler commented Jul 2, 2020

Thanks for the quick fix

me-johnomar added a commit to me-johnomar/ltex-ls that referenced this issue Jan 31, 2024
@me-johnomar @valentjn
Silence output to stdout caused by LanguageTool
f6baee5 
Fixes valentjn/vscode-ltex#68.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentjn valentjn

Labels
1-bug 🐛 Issue type: Bug report (something isn't working as expected) 2-confirmed Issue status: Confirmed, reproducible bug in LTeX 2-upstream Issue status: Bug is caused by some dependency, might have to wait before continuing 3-fixed Issue resolution: Issue has been fixed on the develop branch
Projects
None yet
Milestone
6.0.1
Development

No branches or pull requests
2 participants
@valentjn @ahippler