-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: support additional vCenter entities for privilege rules #362
Conversation
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from the minor grammar issue. Also thanks for cleaning up all the helper functions that weirdly returned a bool along with the err and actual return value. It always felt like some weird anti-pattern.
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #362 +/- ##
==========================================
+ Coverage 38.75% 39.20% +0.45%
==========================================
Files 29 32 +3
Lines 1729 1977 +248
==========================================
+ Hits 670 775 +105
- Misses 987 1106 +119
- Partials 72 96 +24
Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
…l tag & name filtering, clean up vcsim Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
…privilege Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
…validator-labs/validator-plugin-vsphere into feat/additional-entities
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
🤖 I have created a release *beep* *boop* --- ## [0.1.0](v0.0.34...v0.1.0) (2024-09-10) ### ⚠ BREAKING CHANGES * support additional vCenter entities for privilege rules ([#362](#362)) * remove RolePrivilegeValidationRules, add enums to API, remove "cloud" refs and simplify account handling ([#357](#357)) ### Features * support additional vCenter entities for privilege rules ([#362](#362)) ([abe3a94](abe3a94)) ### Docs * fix typos ([f9b63d8](f9b63d8)) * update CR samples ([#367](#367)) ([e6968ba](e6968ba)) ### Dependency Updates * **deps:** update golang.org/x/exp digest to 701f63a ([#364](#364)) ([37af6b3](37af6b3)) * **deps:** update golang.org/x/exp digest to e7e105d ([#355](#355)) ([b67befa](b67befa)) * **deps:** update module github.com/onsi/ginkgo/v2 to v2.20.2 ([#353](#353)) ([f9eab82](f9eab82)) * **deps:** update module github.com/onsi/gomega to v1.34.2 ([#354](#354)) ([d834600](d834600)) * **deps:** update module github.com/validator-labs/validator to v0.1.10 ([#356](#356)) ([3c0c928](3c0c928)) * **deps:** update module github.com/validator-labs/validator to v0.1.9 ([#347](#347)) ([cd8ff75](cd8ff75)) * **deps:** update module sigs.k8s.io/cluster-api to v1.8.2 ([#358](#358)) ([0f7c799](0f7c799)) ### Refactoring * remove RolePrivilegeValidationRules, add enums to API, remove "cloud" refs and simplify account handling ([#357](#357)) ([4388804](4388804)) * rename CloudDriver -> VCenterDriver ([#361](#361)) ([8943ff6](8943ff6)) * vCenter entity type constants ([#360](#360)) ([3fb6f51](3fb6f51)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
## Issue N/A ## Description - Remove RolePrivilegeRules - Add support for privilege rules on all entities - Configure `GroupPrincipals` and `Propagated` for privilege rules - Bump golangci-lint and fix import issues related to `_validator` Requires: - validator-labs/validator-plugin-vsphere#362 --------- Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Issue
N/A
Description
GroupPrincipals
andPropagated
to the privilege rule spec.GroupPrincipals
are used to identify permissions that grant privileges to a user on a specific entity. They're required because non-admin users cannot query the vCenter API to determine their own group membership.Propagated
is a new flag that further qualifies the assignment of privileges to a user on a specific entity.Related: