Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Refactor executePlugins function to operate on a slice of PluginSpecs #211

Closed
ahmad-ibra opened this issue Sep 4, 2024 · 0 comments · Fixed by #206
Closed

🎨 Refactor executePlugins function to operate on a slice of PluginSpecs #211

ahmad-ibra opened this issue Sep 4, 2024 · 0 comments · Fixed by #206
Assignees
Labels
enhancement Enhancement to an existing feature refactoring Refactoring / tech debt

Comments

@ahmad-ibra
Copy link
Collaborator

Summary

Currently the direct execution function, executePlugins operates only on ValidatorConfig. This function will need to be refactored to instead operate on a slice of PluginSpec's if we want to add support for the --crd flag. This is because when passing in a plugins CRD, we will only have access to the PluginSpec and not to the entire validatorConfig (which frankly shouldn't be relevant for direct invocation)

@ahmad-ibra ahmad-ibra added the enhancement Enhancement to an existing feature label Sep 4, 2024
@ahmad-ibra ahmad-ibra self-assigned this Sep 4, 2024
@dosubot dosubot bot added the refactoring Refactoring / tech debt label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature refactoring Refactoring / tech debt
Projects
None yet
1 participant