isURL bug

[tomgrossman]

Hi,
In case there is a reference to a URL not in the beginning of the main URL, the validator returns false.
For example:
this returns true:
validator.isURL('http://test.com?ref=http://test2.com')

but this returns false:
validator.isURL('test.com?ref=http://test2.com')

they are exactly the same except that the second one has no "http://" in the beginning.

[chriso]

I don't think either of those are valid URLs, technically. You need to escape query key/value pairs (e.g. with encodeURIComponent):

> validator.isURL('test.com?ref=http%3A%2F%2Ftest2.com');
true

[chriso]

That said, your browser and command line tools probably interpret the URL correctly without the need for escaped query string values, so we could possibly allow it too.

[chriso]

Ah I see that we already do allow it, as long as the protocol is present. This is a bug then, thanks for reporting.