Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The hardblock was added to prevent Explorer from crashing when ExplorerPatcher is installed. #3053

Closed
Michellehdr opened this issue Mar 25, 2024 · 90 comments

Comments

@Michellehdr
Copy link

Michellehdr commented Mar 25, 2024

Hi Team,

The hardblock was added to prevent Explorer from crashing when ExplorerPatcher is installed. You only need to adjust the setup exe name to get around the block in your new version. We will continue to block ANY version that crashes Explorer.

Please let me know if you have any question.

Thanks
Michelle

@jciurc

This comment was marked as off-topic.

@Amrsatrio
Copy link
Collaborator

Amrsatrio commented Apr 1, 2024

This issue is not repro with the latest prerelease on latest 26090 build. I have my changes to make the 11 taskbar the default on all Windows 11 versions unpushed.

@Michellehdr Michellehdr changed the title Win10 taskbar code removal feature results in ExplorerPatcher crash on WIndows GE build Win10 taskbar code was removed on Windows GE build and above. If user use ExplorerPatcher, crash will occur. Apr 2, 2024
@Michellehdr Michellehdr changed the title Win10 taskbar code was removed on Windows GE build and above. If user use ExplorerPatcher, crash will occur. Win10 taskbar code is removed on Windows GE build and above. If user use ExplorerPatcher, crash will occur. Apr 2, 2024
@Michellehdr Michellehdr changed the title Win10 taskbar code is removed on Windows GE build and above. If user use ExplorerPatcher, crash will occur. Win10 taskbar code is removed on Windows GE build and above. If user continue to use ExplorerPatcher, crash will occur. Apr 3, 2024
@Michellehdr
Copy link
Author

@Amrsatrio please kindly confirm if you received my comment above. Please let me know if you have any question. Thanks a lot!

@pyrates999
Copy link

Hi @Michellehdr as I'm not one of the developers here, I'll let @Amrsatrio reply to this :)

@dxgldotorg
Copy link

As for code removal, is @Michellehdr digging in their heels about not allowing moving or resizing the Taskbar?

@Amrsatrio
Copy link
Collaborator

Hi @Michellehdr, I'm here to let you know that I've received your comment. Sorry for taking a while, I've been having other errands lately. I will make a new release today or tomorrow to make the Windows 10 taskbar no longer an option when run on 26002+.

@Michellehdr
Copy link
Author

@Amrsatrio thanks for the update. Looking forward to the new release. And long termly, it will be great if you could update the app to stop using undocumented code to prevent current and future issues.

@dxgldotorg
Copy link

Since the legacy Explorer Taskbar has been killed off, please consider feedback that re-enables more Windows 10 Taskbar features, especially resizing and moving the Taskbar.

Most people have widescreen displays, and some have ultrawide displays, and thus vertical space is a bit more at a premium, hence why some people like to put their Taskbar on the side of the display.

@Michellehdr Michellehdr changed the title Win10 taskbar code is removed on Windows GE build and above. If user continue to use ExplorerPatcher, crash will occur. Please update the App to not use undocumented code. The current version with undocumented code will cause ExplorerPatcher crash issue. Thus is blocked on Windows Apr 10, 2024
@Michellehdr Michellehdr changed the title Please update the App to not use undocumented code. The current version with undocumented code will cause ExplorerPatcher crash issue. Thus is blocked on Windows The hardblock was added to prevent Explorer from crashing when ExplorerPatcher is installed. Apr 10, 2024
@Amrsatrio
Copy link
Collaborator

Amrsatrio commented Apr 25, 2024

Hi, sorry for taking so long. I have pushed the code where the 10 taskbar is no longer available on 26002 to comply with your decisions. It would be very great if versions 22621.3527.65.1 and above can be whitelisted.

Feel free to close this issue if the 65.1 no longer causes crashes on unreleased GE builds.

@Bec-de-Xorbin
Copy link

Hi, sorry for taking so long. I have pushed the code where the 10 taskbar is no longer available on 26002 to comply with your decisions. It would be very great if versions 22621.3527.65.1 and above can be whitelisted.

Feel free to close this issue if the 65.1 no longer causes crashes on unreleased GE builds.

@Amrsatrio If you read the opening post carefully, they said that you'll just need to rename the ep_setup.exe to something else to lift the block. As far as I can see the new release is still ep_setup.exe. Also it seems that they have retracted the claim that Win10 taskbar code is removed, at least it doesn't appear anymore on the edited post... So as long as it doesn't crash it can inculde the Windows 10 taskbar code.

@dxgldotorg
Copy link

dxgldotorg commented Apr 25, 2024

Hi, sorry for taking so long. I have pushed the code where the 10 taskbar is no longer available on 26002 to comply with your decisions. It would be very great if versions 22621.3527.65.1 and above can be whitelisted.
Feel free to close this issue if the 65.1 no longer causes crashes on unreleased GE builds.

@Amrsatrio If you read the opening post carefully, they said that you'll just need to rename the ep_setup.exe to something else to lift the block. As far as I can see the new release is still ep_setup.exe. Also it seems that they have retracted the claim that Win10 taskbar code is removed, at least it doesn't appear anymore on the edited post... So as long as it doesn't crash it can inculde the Windows 10 taskbar code.

That would explain why the new version blew up when I tried and that I had to rename the uninstaller to get rid of it. But then, I'm on build 26200 Canary, and more legacy code may have been ripped out of Explorer.

@Amrsatrio
Copy link
Collaborator

Amrsatrio commented Apr 25, 2024

@Bec-de-Xorbin I will consider this later.

Also it seems that they have retracted the claim that Win10 taskbar code is removed, at least it doesn't appear anymore on the edited post

I have confirmations that EP and StartAllBack are being blocked due to fighting the DisableWin10Taskbar feature flag. Now in EP the Windows 10 taskbar option is no longer here, so is the code that fights DisableWin10Taskbar.

The system tray-less Windows 10 taskbar code still exists in the latest GE builds, but they still have DisableWin10Taskbar crash bombs sprinkled all over the constructors of various Windows 10 taskbar-related classes, and again, Microsoft isn't happy when someone tries to defuse the bombs for the masses.

@VaiCaDep0893
Copy link

@Amrsatrio
Copy link
Collaborator

@VaiCaDep0893 Stability wise I disagree. Doesn't work if you have more than one input languages.

@dxgldotorg
Copy link

@VaiCaDep0893 Stability wise I disagree. Doesn't work if you have more than one input languages.

Not to mention that Microsoft would probably frown on this project contining Microsoft-owned files.

@David-Castro
Copy link

i do have a backup of windows 11 explorer 22h2
use that while you can
explorer.zip

@pyrates999
Copy link

pyrates999 commented May 1, 2024

Where would this explorer.exe go?

Also, be wary of anyone sending you an executable. Don't just run it or add it to your OS.

@markran
Copy link

markran commented May 1, 2024

If this means there won't be any way to have to get the taskbar on Win11 on the side as well as all the other functionality MSFT has chosen to remove (Quick Launch, etc), then Windows 11 will no longer be usable at our company.

Due to the uncertainty around MSFT's intentions to fulfill their earlier promises about implementing full taskbar functionality in Win11 we've avoided upgrading our computers. Unfortunately, our IT vendor is only offering laptops with Win11 recently. Prior to deployment we'll need to downgrade all new laptops to a Win10 Long Term Maintenance version or the last Win11 version that can be made usable with ExplorerPatcher (and then freeze them on that version).

Does anyone know the final working version of Windows 11?

@David-Castro
Copy link

Where would this explorer.exe go?

Also, be wary of anyone sending you an executable. Don't just run it or add it to your OS.

the explorer.exe goes into the C:\WINDOWS folder.
also, the explorer.exe (22H2 Windows 11) was taken from my system and verified with virustotal, so no virus was detected.
see here for analysis: https://www.virustotal.com/gui/file/698e8a2eabad13876d0af28e82129e47a9cb24f31d6d287dc00d2c1929ed04b5

@David-Castro
Copy link

If this means there won't be any way to have to get the taskbar on Win11 on the side as well as all the other functionality MSFT has chosen to remove (Quick Launch, etc), then Windows 11 will no longer be usable at our company.

Due to the uncertainty around MSFT's intentions to fulfill their earlier promises about implementing full taskbar functionality in Win11 we've avoided upgrading our computers. Unfortunately, our IT vendor is only offering laptops with Win11 recently. Prior to deployment we'll need to downgrade all new laptops to a Win10 Long Term Maintenance version or the last Win11 version that can be made usable with ExplorerPatcher (and then freeze them on that version).

Does anyone know the final working version of Windows 11?

Probably 23H2, because i haven't had any issues running it.

@pyrates999
Copy link

Still recommend against it.

@David-Castro
Copy link

Still recommend against it.

it's the only way

@pyrates999
Copy link

That's not secure to accept executables from strangers.

@dxgldotorg
Copy link

Still recommend against it.

it's the only way

Still, EP needs to put out a build that is fully 26100 compliant to be exempted from the block, and the option of injecting older builds of copyrighted MS binaries is probably not all that legal.

@A7exSchin
Copy link

Just stumbled over this thread while looking for a way to bring the task bar to the left side because it just makes sense on widescreen displays. It reminds me of the time when Microsoft killed the EdgeDeflector and forced users to use Bing and Edge...

If these changes go live it is just a bigger argument for using Linux for work and something like AtlasOS for Gaming.

@doterik
Copy link

doterik commented Jun 15, 2024

I guess this is the right thread for my current problem.

Explorer always restarts. An information window shows that EP will be shut down due to crashes, but nothing happens, Explorer keeps restarting.

Windows 10.0.22635.3785 (latest symbols file downloaded)
EP 22621.3527.65.2 (automatically installed some time ago)

I have restarted the computer a few times but with the same result.

When I tried to uninstall via the command ep_setup.exe /uninstall, a window showed that the uninstall was completed. In connection with this, I received several virus warnings and files quarantined which, for me, are difficult to manage without a 'Desktop'. (The only thing that happened was the window showing that EP is to be disabled now is gone.)

On new reboots, Explorer continues to restart repeatedly. By killing the process, I can run a command prompt, but if I was content with that I might as well install Linux.

What can I do?
How do I get Windows to work again?

@pyrates999
Copy link

@doterik
Copy link

doterik commented Jun 16, 2024

@pyrates999 Thank you for your response.

Unfortunately, the version provided did not resolve the issue.

The behavior remains unchanged; Explorer is caught in an endless restart loop, accompanied by a recurring notification that EP will be disabled - though nothing changes.

I attempted to uninstall EP once more, yet Explorer persists in restarting. This time, the EP notification window is absent; instead, there’s a continuous alert about the symbols file has been downloaded, yet the taskbar remains invisible. I was compelled to terminate the process again.

Following a reboot, the same issue recurs. The notification has disappeared, but Explorer continues to restart endlessly.

Could EP have replaced any Windows files, or might there be registry changes that can be undone?

@Amrsatrio
Copy link
Collaborator

@doterik I have not tested that particular Beta build yet, but will check it out soon to see if something is fixable. In the meantime please delete C:\Windows\dxgi.dll.

@doterik
Copy link

doterik commented Jun 16, 2024

@Amrsatrio That was a quick reply...

Don't have it in \Windows, I suppose you mean \Windows\System32.

What about \Windows\SysWOW64 ?

@Amrsatrio
Copy link
Collaborator

Hm, weird, if Explorer keeps crashing even without that file present it means there is something wrong with that build or your Windows install. Also please do not delete C:\Windows\System32\dxgi.dll, it is a crucial system file.

@doterik
Copy link

doterik commented Jun 16, 2024

@Amrsatrio Hmm...mysterious...

Should I copy the one from \Windows\System32 to \Windows ?

Could running a sfc /scannow help? (I suppose it at least can't hurt.)

@Amrsatrio
Copy link
Collaborator

Amrsatrio commented Jun 16, 2024

No, do not do that copy as well. I don't know about running sfc /scannow honestly, worth a try. I've had similar Explorer crash loops even without EP on beta builds in the past. I can say that Beta builds are unstable sometimes.

@doterik
Copy link

doterik commented Jun 16, 2024

@Amrsatrio Ok, thanks for your answer.

The latest beta version (.3785) started normally. I think it was in connection with when the symbols file was downloaded, at a later time, and then a restart of Explorer that the problems arose. I don't think there was anything wrong with the symbols file, but something may have gone wrong with the restart of Explorer.

I'll try running sfc and we'll see...

@doterik
Copy link

doterik commented Jun 16, 2024

@Amrsatrio SFC didn't help, unfortunately, not a single error.

Come to think of it, isn't \Windows\dxgi.dll from EP, and if so, it was probably removed during uninstall (quite in order).

Thanks anyway for your support.

@raxpyraxp
Copy link

So basically as I understand - there will be no way to stick the taskbar to the top of the screen?
I see that Win11 taskbar has no such option now.
Do someone knows an alternative for this? I don't mind switching to Win11 taskbar if that's how things are going now. Guess I can get used to larger icons, but bottom taskbar is a little bit painful change for me

@robpomeroy
Copy link

Do someone knows an alternative for this?

I don't mean this flippantly: this has made me seriously consider finally switching to a Linux desktop. I would just need to do an audit to check which software I use would need to run in a Win11 VM.

I've had the taskbars at the sides of my dual monitors for so many years that the bottom taskbar feels like a very retrograde step.

@raxpyraxp
Copy link

this has made me seriously consider finally switching to a Linux desktop

I legit want give it a try again. I only moved from Linux as a daily driver because of the online games that I've been playing (don't want to risk my accounts to be banned for cheating as some of them don't play nice with wine/proton) and due to some instability on my hardware that might've been fixed by now

@TheKidRock
Copy link

@Michellehdr Only reason I use EP is to display 2 clocks on the Taskbar. Default clock allows 2 clocks only on hovering but I used Atomic Alarm Clock which lets me display 2 clocks to display 2 different timezones on Taskbar Tray.
On default Windows 11 taskbar, I get this error "Trayclockwclass not found" but after installing EP and enabling Windows 10 taskbar, atomic clock used to work fine. Now, in Windows 11 24H2, neither the clock is working nor EP's Windows 10 taskbar.
So, is it possible to let me have 2 clocks display on Windows 11 taskbar? Is there a solution for Trayclockwclass error? I haven't found any other clocks that have features to display 2 clocks on taskbar.

@Veyilla
Copy link

Veyilla commented Jun 25, 2024

Is there a way to minimize the taskbar and its icons? I find the fixed size unsightly and annoying. That's actually why I downloaded the program, I was never interested in the Win10 taskbar. I would just like it to look smaller again and only show me the time, without the date, as it used to be possible to set under win10.

My operating system is as follows:

Edition: Windows 11 Pro
Version: 24H2
Operating system build: 26120.994
Performance: Windows Feature Experience Pack 1000.26100.6.0

@pyrates999
Copy link

Is there a way to minimize the taskbar and its icons? I find the fixed size unsightly and annoying. That's actually why I downloaded the program, I was never interested in the Win10 taskbar. I would just like it to look smaller again and only show me the time, without the date, as it used to be possible to set under win10.

My operating system is as follows:

Edition: Windows 11 Pro Version: 24H2 Operating system build: 26120.994 Performance: Windows Feature Experience Pack 1000.26100.6.0

Try this: https://www.geeksforgeeks.org/how-to-change-taskbar-size-in-windows-11/

@mrplow
Copy link

mrplow commented Jun 26, 2024

two rows of applications is not possible with 24h2 as far as I can see. Reg tweaks only resize the bar/icons but still don't allow proper resizing. {sarcastic}Good job MS!{/sarcastic}

@AJolly
Copy link

AJolly commented Jul 4, 2024

I don't see the point of the quick launch toolbar anymore since you can now pin applications on the taskbar itself.

Quick launch gives you hotkeys - Win+1, Win+2, Win+3 etc

@Veyilla
Copy link

Veyilla commented Jul 10, 2024

Is there a way to minimize the taskbar and its icons?

Try this: https://www.geeksforgeeks.org/how-to-change-taskbar-size-in-windows-11/

This is not more functional in the new Versions of Windows 11...

@levitation
Copy link

levitation commented Jul 11, 2024

@Michellehdr

@Amrsatrio thanks for the update. Looking forward to the new release. And long termly, it will be great if you could update the app to stop using undocumented code to prevent current and future issues.

Your concern regarding future compatibility is understandable.

At the same time, with all due respect, I am wondering whether you are sure that your request to not use undocumented code complies with EU DMA (https://digital-markets-act.ec.europa.eu/)?

Essentially, Microsoft as a operating system developer and therefore sort of gatekeeper should not create functions which provide unfair advantage to Microsoft's other software. That would be anti-competitive. The functionalities Microsoft implements into the operating system should be available for all software developers, not only to Microsoft. Since these undocumented functionalities are inevitably part of the operating system, then it is fair that other developers use them just as freely as Microsoft themselves would use them.

Ideally, Microsoft should make these functions documented since it can be assumed that internally Microsoft has this documentation available for developers of other Microsoft's software. But if these functions stay undocumented, then at least it should not be requested that others refrain from using them.

Curious, how do these considerations land with you?

PS. I do not represent ExplorerPatcher, I am an independent user and software developer.

@pyrates999
Copy link

I think undocumented code is code that can change with every new update that is released for windows. It's not guaranteed to stay the same. So the compatibility can change if that code changes.

@daxs2
Copy link

daxs2 commented Jul 13, 2024

@Amrsatrio thanks for the update. Looking forward to the new release. And long termly, it will be great if you could update the app to stop using undocumented code to prevent current and future issues.

Maybe if you LISTEN quickly to your users and stop capping Windows features to align to MICROSOFT values and opinions on UI, everything would be great. Another good shot would be to DOCUMENT YOUR entire codebase; anyway, this ir OUR software that WE got to OUR own use.

f#ck M5

@0xF5F5F5
Copy link

0xF5F5F5 commented Jul 16, 2024

@Amrsatrio thanks for the update. Looking forward to the new release. And long termly, it will be great if you could update the app to stop using undocumented code to prevent current and future issues.

Maybe if you LISTEN quickly to your users and stop capping Windows features to align to MICROSOFT values and opinions on UI, everything would be great. Another good shot would be to DOCUMENT YOUR entire codebase; anyway, this ir OUR software that WE got to OUR own use.

f#ck M5

I agree just because the blocker is too strict, and is ironically blocking some people from uninstalling the very product that Microsoft is blocking people from running on their computers.

The blocker should warn the user with a consent prompt (the kind used for UAC), it should warn the user twice, and then run it. I think that would be a decent "compromise". But I just noticed that ExplorerPatcher has a new implementation of the Windows 10 taskbar, I'm interested in seeing how it works. It is claimed to be compatible with 24H2. I always thought that a re-implementation of the taskbar would be necessary because the existing code would be removed from Windows sooner or later. I was more surprised that Microsoft left it in there for this long.

One more thing. I've been using the old taskbar for a while, but for the past month I've been using ExplorerPatcher solely for the Simple Window Switcher. Now I can't work without it. Switching between an app's windows with Alt + Tilde? Microsoft should implement that asap, but they won't. First time I saw it was in Mac OS X, mid-2000s. Obviously other desktops like KDE can be configured to do this. Gnome comes with this functionality, because ever since Gnome 3 Tablet Edition came out they just like to copy Mac OS X (often times a bad interpretation, but still). Anyway, I'm happy that ExplorerPatcher has made as much progress as it has. They even automated the process of compiling ExplorerPatcher, on the user's system, with low friction. It's a great idea, and unheard of in the Windows world!

@kkiris
Copy link

kkiris commented Jul 24, 2024

I get this error when I try to update ExplorerPatcher… Is this the block or something different?
image

If it matters, I'm running Windows 11 Pro 23H2 (build 22635.3936), and my current ExplorerPatcher version is 22621.3810.66.1.

@pyrates999
Copy link

I get this error when I try to update ExplorerPatcher… Is this the block or something different? image

If it matters, I'm running Windows 11 Pro 23H2 (build 22635.3936), and my current ExplorerPatcher version is 22621.3810.66.1.

yes, it is windows defender blocking the pre-release of EP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests