Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win+X is not working when taskbar is set to auto hide #63

Closed
srwhaley opened this issue Oct 10, 2021 · 10 comments
Closed

Win+X is not working when taskbar is set to auto hide #63

srwhaley opened this issue Oct 10, 2021 · 10 comments
Labels
Bug Something isn't working fixed

Comments

@srwhaley
Copy link

I installed the dll file to my C:\Windows directory and restarted file explorer + my PC. Now, the win+x hotkey does not register. Windows key by itself works, and I can right click the start button to bring up the window, but the actual shortcut does not work. Any reason why that would break?

I am currently on v23. Originally installed 24, the hotkey didn't work, so I tried to downgrade, and the hotkey still does not work.

@valinet
Copy link
Owner

valinet commented Oct 10, 2021

Hmmm... I don't know. For me it works, just tested now... so you say right clicking on the Start button opens the power user menu, but pressing Win+X does not?

@valinet
Copy link
Owner

valinet commented Oct 10, 2021

Do you have automatic hide the taskbar on?

@Gaurav-Original-ClassicShellTester
Copy link

Gaurav-Original-ClassicShellTester commented Oct 10, 2021

No issues for me with Win+X whether Taskbar is on auto-hide or not.

I am on Windows 11 22471.1000 and running ExplorerPatcher 22000.194.0.24 built on Oct 10.

Update: Maybe it's working for me because I have both EP and StartAllBack enabled.

@srwhaley, do other hotkeys work like Win+C for Calendar? Or does it bring up that awful Windows 11 Chat app?

@srwhaley
Copy link
Author

It seems that having auto-hide on was the reason it wasn't working, setting the taskbar to always show allows me to use win+x. @Gaurav-Original-ClassicShellTester Win+C also does not work when I have auto-hide on.

@valinet
Copy link
Owner

valinet commented Oct 10, 2021

It seems that having auto-hide on was the reason it wasn't working, setting the taskbar to always show allows me to use win+x. @Gaurav-Original-ClassicShellTester Win+C also does not work when I have auto-hide on.

Yeah, neither does it work for me, I figured that may be a difference. Yeah, it is indeed a bug/problem, I am working on it at the moment, the Win+X menu still has to open regardless whether the taskbar has auto hide on/off. Thanks for the report.

@valinet
Copy link
Owner

valinet commented Oct 10, 2021

@srwhaley @Gaurav-Original-ClassicShellTester It is fixed, 22000.194.0.25 is a new release which contains this fix. Thanks for reporting. Finally implemented properly as specified in #3.

@valinet valinet changed the title Win + x hotkey no longer works Win+X is not working when taskbar is set to auto hide Oct 10, 2021
@valinet valinet added Bug Something isn't working fixed labels Oct 10, 2021
@valinet
Copy link
Owner

valinet commented Oct 10, 2021

No issues for me with Win+X whether Taskbar is on auto-hide or not.

I am on Windows 11 22471.1000 and running ExplorerPatcher 22000.194.0.24 built on Oct 10.

@srwhaley, do other hotkeys work like Win+C for Calendar? Or does it bring up that awful Windows 11 Chat app?

To iterate on that, no shortcuts that in the backend involved programmatically clicking on some button from the taskbar work when the taskbar is hidden, for obvious reasons (the buttons are not on screen anymore). The correct way to toggle these menus, flyouts etc is to inspect the disassembly of shell components and see whether there is an interface that provides access to that functionality. The Start button disassembly from explorer (specifically CPearl::_GetLauncherTipContextMenu) had a good example on how to trigger the Win+X menu, and it just worked if implemented properly, as we already knew it worked as right clicking the Start menu triggers Win+X just fine.

Regarding Win+C, that also works in the "classic" way of clicking the clock in the taskbar via code. I will check at some point, maybe there is an interface for the date time flyout as well that we could call so that this functionality could be implemented in a proper way, as well.

@srwhaley
Copy link
Author

Thanks for the super quick fix!

@valinet
Copy link
Owner

valinet commented Oct 11, 2021

My pleasure. It was quick because I learned quite a few things since 2 months ago approximately when I started working on this ;)

@valinet
Copy link
Owner

valinet commented Oct 11, 2021

No issues for me with Win+X whether Taskbar is on auto-hide or not.
I am on Windows 11 22471.1000 and running ExplorerPatcher 22000.194.0.24 built on Oct 10.
@srwhaley, do other hotkeys work like Win+C for Calendar? Or does it bring up that awful Windows 11 Chat app?

To iterate on that, no shortcuts that in the backend involved programmatically clicking on some button from the taskbar work when the taskbar is hidden, for obvious reasons (the buttons are not on screen anymore). The correct way to toggle these menus, flyouts etc is to inspect the disassembly of shell components and see whether there is an interface that provides access to that functionality. The Start button disassembly from explorer (specifically CPearl::_GetLauncherTipContextMenu) had a good example on how to trigger the Win+X menu, and it just worked if implemented properly, as we already knew it worked as right clicking the Start menu triggers Win+X just fine.

Regarding Win+C, that also works in the "classic" way of clicking the clock in the taskbar via code. I will check at some point, maybe there is an interface for the date time flyout as well that we could call so that this functionality could be implemented in a proper way, as well.

Win+C is now fixed as well, triggered using a new mechanism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working fixed
Projects
None yet
Development

No branches or pull requests

3 participants