-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NGC compilation error with 2.3.0 #1307
Comments
I also get this problem. Angular 2.3.0. Typescript 2.0.10. My workaround was to revert to Angular 2.2.0. |
this is awesome, so you just need to set default value |
@valorkin It isn't that simple. To resolve this we will have to get rid of the static declarations and make this class instance based (instead of calling the methods statically) Then to make the class behave the same, we will have to inject the instance into the NgModule in provided. I will play with that approach and if it work's; I'll raise a PR. |
omfg ... this sounds as a bad news |
@linusbrolin Try revert Angular back to "2.2.4". I am using that version and I don't have any issue. |
@tsoposki Thanks! That specific version seemed to not produce error messages. |
There are v1.1.16-4, who can try it with ng v2.3 |
@valorkin I tried with ng2 "2.3.0" and "2.3.1" with the latest ng2-bootstrap "1.1.16-4" and I am still getting the same issue. |
please try v1.1.16-5 |
I will reopen issue, until fix confirmed |
Please confirm that issue is fixed in v1.1.16-6 |
Hi Valorkin Error at D:/project/node_modules/ng2-bootstrap/typeahead/typeahead-c FYI: I am working on a PR but it's taking a while... |
ok, check v1.1.16-7 |
Thanks for the work you put in, version 1.1.16-7 works with angular 2.3.1. |
awesome, back to docs ;) |
I believe that it would help, it would effectively be your e2e tests. |
When compiling with @angular/compiler-cli@2.3.0
I get the following error:
This is caused by the ng2-bootstrap-config.ts code static variable and that aren't initialized.
https://github.com/valor-software/ng2-bootstrap/blob/development/src/utils/ng2-bootstrap-config.ts
The text was updated successfully, but these errors were encountered: