Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comp(dropdown) fixed disabled tests, removed outdated #1605

Merged
merged 7 commits into from
Feb 28, 2017

Conversation

Le0Michine
Copy link
Contributor

@Le0Michine Le0Michine commented Feb 5, 2017

fixed tests, removed outdated ones.
DropdownService made injectable and added to providers

@codecov-io
Copy link

codecov-io commented Feb 5, 2017

Codecov Report

❗ No coverage uploaded for pull request base (development@8f4a9d4). Click here to learn what that means.

@@              Coverage Diff               @@
##             development    #1605   +/-   ##
==============================================
  Coverage               ?   85.23%           
==============================================
  Files                  ?       85           
  Lines                  ?     2337           
  Branches               ?      301           
==============================================
  Hits                   ?     1992           
  Misses                 ?      246           
  Partials               ?       99
Impacted Files Coverage Δ
src/dropdown/dropdown.config.ts 100% <100%> (ø)
src/dropdown/dropdown.directive.ts 64.63% <100%> (ø)
src/dropdown/dropdown.module.ts 100% <100%> (ø)
src/dropdown/dropdown.service.ts 82.69% <90.9%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f4a9d4...cf3a8eb. Read the comment docs.

Copy link
Member

@valorkin valorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job as always!

@valorkin valorkin merged commit 29dceba into valor-software:development Feb 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants