Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't resolve all parameters for TooltipOptions #1612

Closed
GuskiS opened this issue Feb 6, 2017 · 15 comments
Closed

Can't resolve all parameters for TooltipOptions #1612

GuskiS opened this issue Feb 6, 2017 · 15 comments

Comments

@GuskiS
Copy link

GuskiS commented Feb 6, 2017

Just updated to version 1.3.3, but having this error while doing AoT compilation:
Can't resolve all parameters for TooltipOptions in path/node_modules/ng2-bootstrap/tooltip/tooltip-options.class.d.ts
I'm not using TooltipOptions anywhere. Using webpack 2.2.1, TS 2.1.5, Angular 4.0.beta6.
On JiT works fine.

@damoqiongqiu
Copy link

Same issue

@valorkin
Copy link
Member

I will need to replace it with interface or something... strange it was working fine before

@neilhem
Copy link

neilhem commented Feb 22, 2017

The same error with default JIT compilation

@RomaDotDev
Copy link

Confirm the error for AoT, JiT is fine.
ng2-bootstrap 1.3.3, Angular 4.0.0 RC1, angular-cli 1.0.0 RC0

@GuskiS
Copy link
Author

GuskiS commented Feb 26, 2017

@valorkin This needs a fix because Angular 4 is nearly here.

@ctrl-brk
Copy link

Works in Angular 2 but not in Angular 4

@valorkin
Copy link
Member

I took a look, there are not so many breaking changes for devs, but a lot for lib devs :(

@Iverson
Copy link

Iverson commented Mar 1, 2017

I found workaround:

import { TooltipModule } from 'ng2-bootstrap/tooltip/tooltip.module'

instead of

import { TooltipModule } from 'ng2-bootstrap/tooltip'

just don't import deprecated ng2-bootstrap/tooltip/tooltip-options.class.js which exported automatically from ng2-bootstrap/tooltip/index.js

@ctrl-brk
Copy link

ctrl-brk commented Mar 1, 2017

@Iverson I don't import this module anywhere and still get the error.

@GuskiS
Copy link
Author

GuskiS commented Mar 2, 2017

@valorkin 👍 When will be new NPM version released?

@valorkin
Copy link
Member

valorkin commented Mar 2, 2017

Updated cli to rc.0
tomorrow I want to release 2 versions
With ng v2 and 4

@RomaDotDev
Copy link

@valorkin Please note an interesting side effect.
In my code I use lazy load, AOT compilation and shared factory where init and expose all ng2-bootstrap modules across the app.

When I import all modules directly as @Iverson suggested
import { TooltipModule } from 'ng2-bootstrap/tooltip/tooltip.module'
the size of vendor.bundle.js becomes slightly bigger, but lazy loaded chunks which use shared ng2-bootstrap modules become much smaller.

In result my total AoT tree-shaked, minified and compressed production build is 200kb lighter.

I use Angular 2.4.8, CLI RC0

@ctrl-brk
Copy link

ctrl-brk commented Mar 6, 2017

I'm dying here waiting for the fix :(

@karlhaas
Copy link
Contributor

karlhaas commented Mar 6, 2017

Also waiting for the fix. @valorkin can you tell when the new release will be ready?

@valorkin
Copy link
Member

valorkin commented Mar 6, 2017

https://github.com/valor-software/ng2-bootstrap/releases/tag/v1.4.0

published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants