Instructions for BS4 and ng-cli #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved card class to a surrounding div so text formats correctly with Bootstrap 4
Moved card class to a surrounding div so text formats correctly with Bootstrap 4
shows how to set up for bootstrap 4 in an angular-cli
Codecov Report
@@ Coverage Diff @@
## development #1714 +/- ##
============================================
Coverage 85.44% 85.44%
============================================
Files 85 85
Lines 2295 2295
Branches 300 300
============================================
Hits 1961 1961
Misses 235 235
Partials 99 99Continue to review full report at Codecov.
|
|
Looks great, add a links to landing and readme.md files so it can be found Huge work, thank you! |
|
What do you mean by adding links to landing? Can see where to add links in the .md files but cannot find a landing file. |
|
It am generating landing from MD files |
|
Added links to the new instructions to readme.md and getting-started.md |
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions on how to set up ng2-bootstrap for Bootstrap 4 based on an angular-cli generated project. This should hopefully remove the confusion a few people have over certain components not working when using Bootstrap 4.