Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added exportAs to dropdown directives #785

Merged
merged 4 commits into from
Aug 5, 2016
Merged

Added exportAs to dropdown directives #785

merged 4 commits into from
Aug 5, 2016

Conversation

tiagoroldao
Copy link
Contributor

Fixes #784

@codecov-io
Copy link

codecov-io commented Jul 25, 2016

Current coverage is 81.63% (diff: 100%)

Merging #785 into development will not change coverage

@@           development       #785   diff @@
=============================================
  Files               17         17          
  Lines              539        539          
  Methods            103        103          
  Messages             0          0          
  Branches            69         69          
=============================================
  Hits               440        440          
  Misses              99         99          
  Partials             0          0          

Powered by Codecov. Last update f146a22...c16d904

@valorkin
Copy link
Member

can you please add bs-* prefix?
I am planning to add a name space to bs components anyway

@@ -10,7 +10,7 @@ const MouseEvent = (global as any).MouseEvent as MouseEvent;

@Directive({
selector: '[dropdownToggle]',
exportAs: 'dropdown-toggle'
exportAs: 'bn-dropdown-toggle'

This comment was marked as off-topic.

This comment was marked as off-topic.

@valorkin valorkin added this to the 1.0.25 milestone Aug 5, 2016
@valorkin valorkin merged commit 66531c7 into valor-software:development Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants