fix(tabs): fix select/deselect multiple calls (#2361)

fixes #2005 fixes #1820 fixes #1129
valor-software · Aug 4, 2017 · 5dd456b · 5dd456b
1 parent c0347d7
commit 5dd456b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/spec/tabset.component.spec.ts b/src/spec/tabset.component.spec.ts
@@ -8,7 +8,7 @@ import { TabsetComponent } from '../tabs/tabset.component';
 const html = `
   <tabset #tabset [justified]="isJustified"
           [vertical]="isVertical">
-    <tab heading="tab0">tab0 content</tab>
+    <tab heading="tab0" (deselect)="_deselect($event)">tab0 content</tab>
     <tab *ngFor="let tab of tabs"
          [disabled]="tab.disabled"
          [customClass]="tab.customClass"

diff --git a/src/tabs/tab.directive.ts b/src/tabs/tab.directive.ts
@@ -37,12 +37,15 @@ export class TabDirective implements OnInit, OnDestroy {
   }
 
   public set active(active: boolean) {
+    if (this._active === active) {
+      return;
+    }
     if (this.disabled && active || !active) {
-      if (!active) {
+      if (this._active && !active) {
+        this.deselect.emit(this);
         this._active = active;
       }
 
-      this.deselect.emit(this);
       return;
     }