Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datepicker: selectionDone triggered on any ngModel change #1095

Closed
renehamburger opened this issue Oct 6, 2016 · 3 comments
Closed

Datepicker: selectionDone triggered on any ngModel change #1095

renehamburger opened this issue Oct 6, 2016 · 3 comments

Comments

@renehamburger
Copy link

I am aware that a complete overhaul of the datepicker is on the way, but this issue has been introduced very recently (between ng2-bootstrap 1.1.5 and 1.1.7). In 1.1.5, 'selectionDone' was only triggered when the user made a selection in the datepicker, but in 1.1.7 and later, any change to datepicker's ngModel now triggers it, including the very first one on initialisation. (This is particularly devastating for any popup version of the datepicker closing the popup on selectionDone.)

@valorkin
Copy link
Member

valorkin commented Oct 7, 2016

yep, this behavior was introduced with fb6d532

@valorkin
Copy link
Member

valorkin commented Oct 7, 2016

please check v1.1.11

@renehamburger
Copy link
Author

Yes, great. Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants