Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accordion): add output for isOpen state changes #2619

Merged
merged 10 commits into from
Oct 23, 2017

Conversation

steelsojka
Copy link
Contributor

@steelsojka steelsojka commented Sep 11, 2017

This fixes issue #2617 without making any breaking changes. This can solve several issues with accordion open state as well.

Closes #556

@codecov
Copy link

codecov bot commented Sep 11, 2017

Codecov Report

Merging #2619 into development will increase coverage by 0.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development   #2619      +/-   ##
==============================================
+ Coverage        70.69%   70.7%   +0.01%     
==============================================
  Files              137     137              
  Lines             4159    4165       +6     
  Branches           735     737       +2     
==============================================
+ Hits              2940    2945       +5     
  Misses             914     914              
- Partials           305     306       +1
Impacted Files Coverage Δ
src/accordion/accordion-group.component.ts 90.32% <87.5%> (-1.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 479b046...4a7966a. Read the comment docs.

@IlyaSurmay
Copy link
Contributor

@steelsojka hey, thanks for PR!
only one note, isOpenChanges should be renamed to isOpenChange
so you can use two way data binding

@valorkin valorkin added this to the v2.0.0 milestone Sep 14, 2017
@steelsojka
Copy link
Contributor Author

@IlyaSurmay I thought about that, but I thought it would be a breaking change since it would have broken one way bindings. I was thinking you would need to emit on isOpenChange instead of modifying the internal state, but you could modify the state and notify without breaking current behavior. I'll make the change.

…ootstrap into development

* 'development' of https://github.com/valor-software/ngx-bootstrap:
  fix(modals): fix issues with renderer2 in modal service
  fix(dropdown): prevent event propogation if dropdown toggle clicked
  fix(datepicker): added zindex to show datepicker above input fields
  fix(tests): fixed tests, change renderer to renderer2
  fix(dropdown): fix ngv4 dropdowns (valor-software#2644)
  fix(tabs): fix default tab selection (valor-software#2643)
  feat(timepicker): replace glyphicons with custom icons (valor-software#2640)
  fix(modal): fix bsModalRef paths in demos (valor-software#2638)
  feat(rating): remove glyphicons, add custom template support (valor-software#2631)
  fix(datepicker): fix long date format (valor-software#2630)
  feat(moment-ts): added czech locale (valor-software#2642)
  feat(package): drop support of ng v2 and add support of ng v4 and v5 (valor-software#2602)
@IlyaSurmay
Copy link
Contributor

Tests are failing :( Please fix them, then we'll merge it.

@valorkin valorkin modified the milestone: v2.0.0 Oct 20, 2017
@valorkin
Copy link
Member

@steelsojka thanks for your contribution! ;)

@valorkin valorkin merged commit 663f078 into valor-software:development Oct 23, 2017
@psined1
Copy link

psined1 commented Oct 23, 2017

Hi, any idea when is this going live?

@valorkin
Copy link
Member

I am trying to publish small versions each Thursday, will be available as @next version
docs are here http://ngx-bootstrap.surge.sh/#/

@steelsojka
Copy link
Contributor Author

@IlyaSurmay Thanks for fixing these tests and getting this working. I've been busy and wasn't able to get to them. I look forward to seeing this in a release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

accordion events
5 participants