-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(accordion): add output for isOpen state changes #2619
Conversation
Codecov Report
@@ Coverage Diff @@
## development #2619 +/- ##
==============================================
+ Coverage 70.69% 70.7% +0.01%
==============================================
Files 137 137
Lines 4159 4165 +6
Branches 735 737 +2
==============================================
+ Hits 2940 2945 +5
Misses 914 914
- Partials 305 306 +1
Continue to review full report at Codecov.
|
@steelsojka hey, thanks for PR! |
@IlyaSurmay I thought about that, but I thought it would be a breaking change since it would have broken one way bindings. I was thinking you would need to emit on |
…ootstrap into development * 'development' of https://github.com/valor-software/ngx-bootstrap: fix(modals): fix issues with renderer2 in modal service fix(dropdown): prevent event propogation if dropdown toggle clicked fix(datepicker): added zindex to show datepicker above input fields fix(tests): fixed tests, change renderer to renderer2 fix(dropdown): fix ngv4 dropdowns (valor-software#2644) fix(tabs): fix default tab selection (valor-software#2643) feat(timepicker): replace glyphicons with custom icons (valor-software#2640) fix(modal): fix bsModalRef paths in demos (valor-software#2638) feat(rating): remove glyphicons, add custom template support (valor-software#2631) fix(datepicker): fix long date format (valor-software#2630) feat(moment-ts): added czech locale (valor-software#2642) feat(package): drop support of ng v2 and add support of ng v4 and v5 (valor-software#2602)
c12d6b9
to
6ff331a
Compare
Tests are failing :( Please fix them, then we'll merge it. |
@steelsojka thanks for your contribution! ;) |
Hi, any idea when is this going live? |
I am trying to publish small versions each Thursday, will be available as @next version |
@IlyaSurmay Thanks for fixing these tests and getting this working. I've been busy and wasn't able to get to them. I look forward to seeing this in a release! |
This fixes issue #2617 without making any breaking changes. This can solve several issues with accordion open state as well.
Closes #556