Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): if min date is last day of a month #3113

Merged
merged 1 commit into from
Nov 27, 2017

Conversation

valorkin
Copy link
Member

user should be able to navigate into that month

fixes #3102

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

user should be able to navigate into

fixes #3102
@valorkin valorkin added this to the v2.0.0 milestone Nov 27, 2017
@ghost ghost assigned valorkin Nov 27, 2017
@ghost ghost added the in progress label Nov 27, 2017
@valorkin valorkin merged commit ec445e2 into development Nov 27, 2017
@ghost ghost removed the in progress label Nov 27, 2017
@valorkin valorkin deleted the fix-datepicker-min-max-boundaries branch November 27, 2017 13:33
@codecov
Copy link

codecov bot commented Nov 27, 2017

Codecov Report

Merging #3113 into development will decrease coverage by 1.49%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development    #3113     +/-   ##
==============================================
- Coverage        65.44%   63.94%   -1.5%     
==============================================
  Files              209      209             
  Lines             5617     5617             
  Branches           988      988             
==============================================
- Hits              3676     3592     -84     
  Misses            1678     1678             
- Partials           263      347     +84
Impacted Files Coverage Δ
src/datepicker/engine/flag-days-calendar.ts 15.62% <ø> (ø) ⬆️
src/datepicker/utils/bs-calendar-utils.ts 34.78% <0%> (ø) ⬆️
src/component-loader/component-loader.factory.ts 66.66% <0%> (-33.34%) ⬇️
...themes/bs/bs-datepicker-day-decorator.directive.ts 80% <0%> (-20%) ⬇️
...icker/themes/bs/bs-days-calendar-view.component.ts 63.15% <0%> (-10.53%) ⬇️
src/tabs/ng-transclude.directive.ts 50% <0%> (-10%) ⬇️
src/tabs/tab.directive.ts 89.13% <0%> (-8.7%) ⬇️
...emes/bs/bs-datepicker-navigation-view.component.ts 83.33% <0%> (-8.34%) ⬇️
src/collapse/collapse.directive.ts 89.74% <0%> (-7.7%) ⬇️
src/rating/rating.component.ts 68.33% <0%> (-6.67%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60f8b31...3844b7f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BsDatepicker - Unable to return to previous month if minDate is the last day in month
2 participants