Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): add es2015 support #3202

Merged
merged 3 commits into from
Dec 6, 2017
Merged

feat(build): add es2015 support #3202

merged 3 commits into from
Dec 6, 2017

Conversation

IlyaSurmay
Copy link
Contributor

fixes #3134

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.

Copy link
Member

@valorkin valorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So huge config

const dist = 'dist-es2015';
const tsconfigPath = '.tmp/tsconfig.json';

fs.copy(src, tmp)

This comment was marked as off-topic.

@codecov
Copy link

codecov bot commented Dec 5, 2017

Codecov Report

Merging #3202 into development will increase coverage by 0.42%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3202      +/-   ##
===============================================
+ Coverage         65.2%   65.63%   +0.42%     
===============================================
  Files              209      209              
  Lines             5653     5607      -46     
  Branches           996      885     -111     
===============================================
- Hits              3686     3680       -6     
- Misses            1705     1731      +26     
+ Partials           262      196      -66
Impacted Files Coverage Δ
demo/src/app/app.component.ts 34.28% <0%> (ø) ⬆️
src/datepicker/bs-datepicker-input.directive.ts 29.09% <0%> (ø) ⬆️
src/index.ts 100% <0%> (ø) ⬆️
...c/datepicker/bs-daterangepicker-input.directive.ts 26.66% <0%> (ø) ⬆️
src/bs-moment/index.ts 100% <0%> (ø) ⬆️
src/datepicker/reducer/bs-datepicker.effects.ts 17.64% <0%> (ø) ⬆️
...themes/bs/bs-datepicker-day-decorator.directive.ts 100% <0%> (ø) ⬆️
src/sortable/index.ts 100% <0%> (ø) ⬆️
src/modal/bs-modal.service.ts 22.85% <0%> (ø) ⬆️
...ker/themes/bs/bs-datepicker-container.component.ts 38.7% <0%> (ø) ⬆️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 671d573...4a77e12. Read the comment docs.


async function createEs2015Bundle() {
console.log('Copying src to temp folder');
await fs.copy(src, tmp);

This comment was marked as off-topic.

@valorkin valorkin merged commit 735101c into development Dec 6, 2017
@ghost ghost removed the in progress label Dec 6, 2017
@valorkin valorkin deleted the feat-es2015 branch December 6, 2017 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(build): TypeError: Class constructor BehaviorSubject cannot be invoked without 'new'
2 participants