Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BsModalService's enter key event how to solve multiple problems? #3356

Closed
elpmisu opened this issue Dec 25, 2017 · 2 comments
Closed

BsModalService's enter key event how to solve multiple problems? #3356

elpmisu opened this issue Dec 25, 2017 · 2 comments
Assignees
@IlyaSurmay
Labels
comp(modal) effort1: easy (hours) issue

Comments

@elpmisu
Copy link

elpmisu commented Dec 25, 2017

When I create a modal with BsModalService, Enter key will create multiple modal
@elpmisu
Copy link
Author

elpmisu commented Dec 25, 2017

How can I solve this problem？

@IlyaSurmay
Copy link
Contributor

That's happening because modal doesn't focus its root element so button remains focused and pressing enter is triggering function that shows modal. This will be fixed in future release, meanwhile, you can manually focus something in modal after it's shown.

@IlyaSurmay IlyaSurmay mentioned this issue Dec 25, 2017
Merged
2 tasks
@ghost ghost assigned IlyaSurmay Dec 25, 2017
@ghost ghost added the in progress label Dec 25, 2017
@ghost ghost removed the in progress label Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IlyaSurmay IlyaSurmay

Labels
comp(modal) effort1: easy (hours) issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@IlyaSurmay @elpmisu