Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(demo): fix favicon image #3381

Merged
merged 1 commit into from
Jan 10, 2018
Merged

chore(demo): fix favicon image #3381

merged 1 commit into from
Jan 10, 2018

Conversation

EvilAlexei
Copy link
Contributor

  • Added 16 and 32 ngx-bootstrap favicons

fixes #3291

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Jan 2, 2018

Codecov Report

Merging #3381 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #3381   +/-   ##
============================================
  Coverage        64.98%   64.98%           
============================================
  Files              210      210           
  Lines             5695     5695           
  Branches          1002     1002           
============================================
  Hits              3701     3701           
  Misses            1729     1729           
  Partials           265      265

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf1411a...5e37717. Read the comment docs.

Copy link
Member

@valorkin valorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

favicons//favicon-16x16.png doubled slash?

@@ -8,7 +8,8 @@
<meta name="description" content="Bootstrap 3 and Bootstrap 4 widgets for Angular: autocomplete, accordion, alert, buttons, carousel, collapse, dropdown, pagination, popover, progressbar, rating, tabset, timepicker, tooltip, typeahead, sortable, tabs">
<meta name="viewport" content="width=device-width, initial-scale=1">

<link rel="icon" href="data:;base64,iVBORw0KGgo=">
<link rel="icon" type="image/png" sizes="32x32" href="assets/images/favicons//favicon-32x32.png">

This comment was marked as off-topic.

@valorkin valorkin changed the title fix(demo): fix favicon image chore(demo): fix favicon image Jan 5, 2018
@valorkin valorkin added this to the v2.0.0 milestone Jan 5, 2018
- Added new 16 and 32 ngx-bootstrap favicons
@valorkin valorkin merged commit 005701d into development Jan 10, 2018
@valorkin valorkin deleted the fix-favicon-replace branch January 10, 2018 11:49
@ghost ghost removed the in progress label Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(demo): favicon is not shown
2 participants