-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(demo): fix favicon image #3381
Conversation
Codecov Report
@@ Coverage Diff @@
## development #3381 +/- ##
============================================
Coverage 64.98% 64.98%
============================================
Files 210 210
Lines 5695 5695
Branches 1002 1002
============================================
Hits 3701 3701
Misses 1729 1729
Partials 265 265 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
favicons//favicon-16x16.png
doubled slash?
demo/src/index.html
Outdated
@@ -8,7 +8,8 @@ | |||
<meta name="description" content="Bootstrap 3 and Bootstrap 4 widgets for Angular: autocomplete, accordion, alert, buttons, carousel, collapse, dropdown, pagination, popover, progressbar, rating, tabset, timepicker, tooltip, typeahead, sortable, tabs"> | |||
<meta name="viewport" content="width=device-width, initial-scale=1"> | |||
|
|||
<link rel="icon" href="data:;base64,iVBORw0KGgo="> | |||
<link rel="icon" type="image/png" sizes="32x32" href="assets/images/favicons//favicon-32x32.png"> |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
3949e29
to
9412d00
Compare
- Added new 16 and 32 ngx-bootstrap favicons
9412d00
to
5e37717
Compare
fixes #3291
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.