Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows support #10

Open
wants to merge 87 commits into
base: main
Choose a base branch
from
Open

Windows support #10

wants to merge 87 commits into from

Conversation

fpseverino
Copy link
Member

@fpseverino fpseverino commented Sep 6, 2024 •
edited
Loading

Issue #9

Originally authored by @compnerd in marmelroy#246

  • Add support for Windows
  • Add Windows CI tests

@fpseverino fpseverino added the enhancement New feature or request label Sep 6, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.38710% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.60%. Comparing base (567d515) to head (76f1c5a).

Files with missing lines Patch % Lines
Sources/Zip/Zip.swift 98.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
+ Coverage   96.07%   96.60%   +0.53%     
==========================================
  Files           7        7              
  Lines         331      324       -7     
==========================================
- Hits          318      313       -5     
+ Misses         13       11       -2
Files with missing lines Coverage Δ
Sources/Zip/ArchiveFile.swift 100.00% <100.00%> (ø)
Sources/Zip/Date+dosDate.swift 100.00% <ø> (ø)
Sources/Zip/QuickZip.swift 100.00% <ø> (ø)
Sources/Zip/ZipCompression.swift 100.00% <ø> (ø)
Sources/Zip/ZipUtilities.swift 100.00% <100.00%> (ø)
Sources/Zip/Zip.swift 94.38% <98.00%> (+1.02%) ⬆️

@fpseverino fpseverino mentioned this pull request Sep 6, 2024
Open
@fpseverino fpseverino marked this pull request as draft September 6, 2024 15:24
@fpseverino fpseverino linked an issue Sep 6, 2024 that may be closed by this pull request
Incorporate @compnerd's patch for Windows support #9
Open
@fpseverino fpseverino marked this pull request as ready for review September 7, 2024 16:37
@fpseverino fpseverino marked this pull request as draft September 7, 2024 17:39
@fpseverino fpseverino marked this pull request as ready for review September 8, 2024 21:48
@fpseverino fpseverino marked this pull request as ready for review September 22, 2024 09:34
@fpseverino fpseverino marked this pull request as draft September 22, 2024 10:37
@fpseverino fpseverino marked this pull request as ready for review September 28, 2024 09:15
@fpseverino fpseverino marked this pull request as draft September 28, 2024 09:38
@fpseverino fpseverino marked this pull request as ready for review September 29, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptoffy ptoffy ptoffy left review comments

@gwynne gwynne Awaiting requested review from gwynne

@0xTim 0xTim Awaiting requested review from 0xTim

@MahdiBM MahdiBM Awaiting requested review from MahdiBM

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorporate @compnerd's patch for Windows support
2 participants
@fpseverino @ptoffy