Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semver("1.0", NPM).satisfies("1.0") is false #51

Open
dac2k9 opened this issue Nov 5, 2020 · 1 comment
Open

Semver("1.0", NPM).satisfies("1.0") is false #51

dac2k9 opened this issue Nov 5, 2020 · 1 comment

Comments

@dac2k9
Copy link

dac2k9 commented Nov 5, 2020

Semver("1.0", NPM).satisfies("1.0") will return false, while
Semver("1.0", NPM).satisfies("=1.0") will return true.

The one used by NPM states "A leading "=" or "v" character is stripped off and ignored." so I think this is a bug? The docs at
https://www.npmjs.com/package/semver also states
"= Equal. If no operator is specified, then equality is assumed, so this operator is optional, but MAY be included."

@piotrooo
Copy link

@dac2k9 if you are still interesting, I've made copy of this lib and fix bug reported by you. Look for version 2.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants