Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post UISI Autoreport clearn-up #5938

Closed
langleyd opened this issue Mar 29, 2022 · 0 comments · Fixed by #5945
Closed

Post UISI Autoreport clearn-up #5938

langleyd opened this issue Mar 29, 2022 · 0 comments · Fixed by #5945
Assignees
@langleyd
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Comments

@langleyd
Copy link
Member

langleyd commented Mar 29, 2022 •
edited
Loading

There were a couple of items that needed to be cleaned up after #5017

  • There was a preferred implementation detail here (Moving a some logic back to MxSession)
  • An incorrect line added here, that adds the session a second time to the _callPresenter
@langleyd langleyd self-assigned this Mar 29, 2022
@pixlwave pixlwave added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Mar 29, 2022
@langleyd langleyd mentioned this issue Mar 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@langleyd langleyd

Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Post UISI Autoreporter cleanup element-hq/element-ios
2 participants
@pixlwave @langleyd