Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/join requests with malformed body #6481

Closed
richvdh opened this issue Jul 26, 2022 · 0 comments · Fixed by matrix-org/matrix-ios-sdk#1539
Closed

/join requests with malformed body #6481

richvdh opened this issue Jul 26, 2022 · 0 comments · Fixed by matrix-org/matrix-ios-sdk#1539
Labels
A-SDK T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Comments

@richvdh
Copy link
Member

richvdh commented Jul 26, 2022

We see lots of this on requests to POST /_matrix/client/r0/join/{roomIdOrAlias} from clients with user-agents like Riot/1.8.23 (iPhone; iOS 15.5; Scale/2.00):

2022-07-26 00:27:14,236 - synapse.http.servlet - 663 - WARNING - POST-1099409 - Unable to parse JSON: Expecting value: line 1 column 1 (char 0) (b'')

... which suggests it is making requests with a malformed (empty?) body. Currently Synapse accepts this, but it's not spec-compliant and we'll be fixing this in Synapse soon: matrix-org/synapse#13388.

Please could you make sure to include (at least) an empty json object in the request body?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-SDK T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Send an empty dictionary when calling /join to be spec compliant. matrix-org/matrix-ios-sdk
2 participants
@richvdh @pixlwave