Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stuck unread when latest message is in a thread #25623

Closed
Tracked by #24392
andybalaam opened this issue Jun 19, 2023 · 7 comments
Closed
Tracked by #24392

Stuck unread when latest message is in a thread #25623

andybalaam opened this issue Jun 19, 2023 · 7 comments
Assignees
@t3chguy
Labels
A-Notifications A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@andybalaam
Copy link
Member

andybalaam commented Jun 19, 2023 •
edited
Loading

Steps to reproduce

  1. In another room, see that my room is bold in the room list.
  2. Click it. See there is nothing to read. Select "Mark room as read"
  3. Go to a different room. See the room is still bold.

Outcome

What did you expect?

I expected the room would be not-bold when there were no messages to read.

What happened instead?

The room stays bold even though I have read the messages.

Notif debug:
image

Latest message in the main timeline is a thread root with

  "origin_server_ts": 1687165734170,
  "event_id": "$DuAyIfJNk7Jx95TJJmdXTSfaUocj02S3e0KoW5Pwkks",:

image

(Is it weird that this message, which itself is a thread root, has a thread root ID that is not its thread?)

The actual last message in the room, whose ID matches the read receipt, is in the thread (the above message is the root):

  "origin_server_ts": 1687166511424,
  "event_id": "$OT77EQVVh7xyyhOtkdcpb8R_Xf9dF2Oct6QzU8jK_eo",

image

Operating system

Ubuntu 22.04

Browser information

Firefox 114.0.1

URL for webapp

https://develop.element.io

Application version

Element version: 2b31b8d-react-97765613bc7b-js-9c62d1544791 Olm version: 3.2.14

Homeserver

matrix.org

Will you send logs?

Yes
@andybalaam
Copy link
Member Author

image

@andybalaam
Copy link
Member Author

image

Confirmed in sync accumulator, I have a receipt for $OTT77.. and nothing for $DuAyI...

@andybalaam
Copy link
Member Author

image

$OTT77... is the last event in the timeline, and $DuAyI... is earlier.

Also, their timestamps agree with this ordering.

@andybalaam
Copy link
Member Author

Generally, the timestamp order is aligned with the order in the accumulator:

image

@weeman1337 weeman1337 added A-Threads A-Notifications S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jun 19, 2023
@weeman1337 weeman1337 mentioned this issue Jun 19, 2023
Open
@andybalaam
Copy link
Member Author

This seems to have gone away when I restarted my computer and/or refreshed my browser.

@t3chguy t3chguy self-assigned this Jul 25, 2023
@t3chguy
Copy link
Member

t3chguy commented Jul 25, 2023

I believe this has been fixed

@t3chguy t3chguy closed this as completed Jul 25, 2023
@andybalaam
Copy link
Member Author

Agreed - I haven't had any stuck unreads for a couple of weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Notifications A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andybalaam @t3chguy @weeman1337